Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Mirror Chrome Desktop onto Chromium browsers when null #3748

Closed
wants to merge 3 commits into from

Conversation

queengooborg
Copy link
Collaborator

This PR is created by a simple script that mirrors the compatibility data of all APIs from Chrome to all other Chromium-based browsers (Chrome Android, Opera, Opera Android, Samsung Internet, and Webview) when they are set to "null". This should help reduce inconsistencies in the browser data.

@ddbeck
Copy link
Collaborator

ddbeck commented Apr 9, 2019

@Elchi3 any thoughts on this? My hunch is that this sort of mirroring should probably be done explicitly (e.g., with pointer proposals like #1681 and #1799), but I'm not sure if you want to wait for the capability or if you even intend to act on those proposals

@Elchi3
Copy link
Member

Elchi3 commented Apr 9, 2019

I think this is too gigantic and I haven't looked into it in details yet. Deriving versions from Chrome for other Chromium-based browsers is certainly a valid approach, but I'm unsure how we want to vet this exactly yet. I think we can leave this here for us to look at as we are working on similar mass updates first. Also, I'd like to get to #3264 so that we first have engine versions added to maybe prevent mistakes with this kind of mapping.

The feature imports / json pointer PRs you've mentioned should probably be closed. I think they are adding too much complexity and would likely prevent the scripts and mass-updates that @foolip and @vinyldarkscratch have worked on from being useful.

@ddbeck ddbeck added the not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Apr 10, 2019
@ddbeck
Copy link
Collaborator

ddbeck commented Apr 10, 2019

The feature imports / json pointer PRs you've mentioned should probably be closed. I think they are adding too much complexity and would likely prevent the scripts and mass-updates that @foolip and @vinyldarkscratch have worked on from being useful.

@Elchi3 That's completely reasonable and I support that position. Given that, would you do the honors of closing #1681, #813, #1799, and #2761? I think it would be good to explicitly say that bulk updates are our preferred approach right now and that we're not currently considering deduplicating version data.

@Elchi3
Copy link
Member

Elchi3 commented Apr 10, 2019

Thanks Daniel, I went ahead I closed these to no longer set any expectations there.

@queengooborg
Copy link
Collaborator Author

Given that Opera Android versions were merged in as well, this PR needs to be recreated. I’m going to separate this into smaller PRs for each Chromium browser, making the review process easier. ;)

@queengooborg queengooborg deleted the api/sync-chromium branch April 12, 2019 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants