Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for version ranges #4583

Merged
merged 10 commits into from
Aug 12, 2019
Merged

Add support for version ranges #4583

merged 10 commits into from
Aug 12, 2019

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Aug 8, 2019

This replaces #3881

ExE-Boss and others added 8 commits August 8, 2019 12:56
…B-Forks#2)

* Mark version ranges as `true` values in stats script

Co-Authored-By: Vinyl Darkscratch <vinyldarkscratch@gmail.com>

* refactor(scripts): Format `statistics.js`

Co-Authored-By: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
Co-Authored-By: Vinyl Darkscratch <vinyldarkscratch@gmail.com>
  I personally don’t like this, as it’s very hard to type.
@Elchi3 Elchi3 added the linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. label Aug 8, 2019
@Elchi3 Elchi3 requested a review from ddbeck August 8, 2019 11:41
@Elchi3 Elchi3 added the schema ⚙️ Isses or pull requests regarding the JSON schema files used in this project. label Aug 8, 2019
@ddbeck
Copy link
Collaborator

ddbeck commented Aug 8, 2019

@Elchi3 I know this is a priority, but I've run out of time today. I'll review this tomorrow.

@Elchi3
Copy link
Member Author

Elchi3 commented Aug 8, 2019

@ddbeck no worries at all! There is no rush needed, better to get this right than to get this in fast :)

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good! One suggestion to consider, but I'm happy with this as-is. 🎉

schemas/compat-data-schema.md Show resolved Hide resolved
@ddbeck
Copy link
Collaborator

ddbeck commented Aug 12, 2019

A long time coming! Thank you @Elchi3 and @ExE-Boss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. schema ⚙️ Isses or pull requests regarding the JSON schema files used in this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants