-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for version ranges #4583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…B-Forks#2) * Mark version ranges as `true` values in stats script Co-Authored-By: Vinyl Darkscratch <vinyldarkscratch@gmail.com> * refactor(scripts): Format `statistics.js` Co-Authored-By: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
Co-Authored-By: Vinyl Darkscratch <vinyldarkscratch@gmail.com>
I personally don’t like this, as it’s very hard to type.
Elchi3
added
the
linter 🏡
Issues or pull requests regarding the tests / linter of the JSON files.
label
Aug 8, 2019
Elchi3
added
the
schema ⚙️
Isses or pull requests regarding the JSON schema files used in this project.
label
Aug 8, 2019
ExE-Boss
approved these changes
Aug 8, 2019
@Elchi3 I know this is a priority, but I've run out of time today. I'll review this tomorrow. |
@ddbeck no worries at all! There is no rush needed, better to get this right than to get this in fast :) |
ddbeck
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good! One suggestion to consider, but I'm happy with this as-is. 🎉
19 tasks
This was referenced Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #3881