Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): Correct XMLDocument support information #5246

Merged
merged 6 commits into from
May 31, 2020
Merged

fix(api): Correct XMLDocument support information #5246

merged 6 commits into from
May 31, 2020

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Dec 2, 2019 •
edited
Loading

@ghost ghost added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 2, 2019
@queengooborg
Copy link
Collaborator

queengooborg commented Dec 2, 2019 •
edited
Loading

Hey @ExE-Boss, thanks for the PR! I'm currently reviewing this and have found that in Chrome, XMLDocument is also an alias for Document since Chrome <26 (which makes sense considering it's powered by WebKit at that time); in fact, even as far back as Safari 3, maybe even before. It then became its own API in Chrome 34 as your data states.

Lemme see if I can dig up Safari's real version number for XMLDocument aliasing Document...

@queengooborg queengooborg self-requested a review December 2, 2019 04:10
queengooborg
queengooborg requested changes Dec 5, 2019
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like support was added in Safari 3 for the XMLDocument alias. Can we update our data for Safari and Chrome to reflect this?

@queengooborg
Copy link
Collaborator

Hey @ExE-Boss, do you plan to return to this PR?

@ExE-Boss ExE-Boss force-pushed the api/xml-document/fix-compat-data branch from 65f6d1a to 24cdde1 Compare December 28, 2019 10:38
@ExE-Boss ExE-Boss force-pushed the api/xml-document/fix-compat-data branch from 24cdde1 to d35c10d Compare December 28, 2019 10:42
queengooborg
queengooborg reviewed Dec 28, 2019
View reviewed changes
api/XMLDocument.json Outdated Show resolved Hide resolved
queengooborg
queengooborg requested changes Jan 15, 2020
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Sorry for not reviewing sooner, apparently I forgot to hit "Submit" before, whoops!)

api/XMLDocument.json Show resolved Hide resolved
@ExE-Boss ExE-Boss force-pushed the api/xml-document/fix-compat-data branch from d61c456 to 88b158e Compare January 15, 2020 11:35
@ExE-Boss ExE-Boss mentioned this pull request Jan 15, 2020
Closed
@queengooborg
Copy link
Collaborator

Since this PR has changes requested that depend on the linter to be fixed (see #5501), I'm going to mark this as "not ready" for the time being. Let's come back to it when the linter issues are resolved!

@queengooborg queengooborg added the not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Jan 26, 2020
@wbamberg wbamberg removed their request for review January 26, 2020 04:04
@queengooborg queengooborg mentioned this pull request Jan 26, 2020
Merged
queengooborg
queengooborg reviewed May 31, 2020
View reviewed changes
api/XMLDocument.json Outdated Show resolved Hide resolved
@ExE-Boss @queengooborg
fix(api/XMLDocument): Address review comments
13a32ae 
Co-authored-by: Queen Vinyl Darkscratch <vinyldarkscratch@gmail.com>
queengooborg
queengooborg approved these changes May 31, 2020
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you -- and now, the moment we've been waiting for: merge time!

(P.S. no need to specifically request my review after changes. I remain subscribed to PRs I comment on. 😉 )

@queengooborg queengooborg merged commit 761d569 into mdn:master May 31, 2020
@ExE-Boss ExE-Boss deleted the api/xml-document/fix-compat-data branch May 31, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ExE-Boss @queengooborg