Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description of WebView #5534

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

queengooborg
Copy link
Collaborator

Fixes #5185. There was some confusion about if WebView referred to the Chrome versions as well, as the docs stated "the former stock browser". This PR rewords the description a little bit for accuracy.

@ghost ghost added docs ✍️ Issues or pull requests regarding the documentation of this project. schema ⚙️ Isses or pull requests regarding the JSON schema files used in this project. labels Jan 22, 2020
@jpmedley
Copy link
Collaborator

Looks good to me.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit 25bf052 into mdn:master Jan 23, 2020
@queengooborg queengooborg deleted the docs/webview-description branch January 23, 2020 10:59
@queengooborg
Copy link
Collaborator Author

Aw crap... I didn't notice until just now, but apparently Prettier on my system kicked in for this file and I forgot to revert the changes before sending the PR. Oops... >~<

(That does remind me, though: we should certainly go through and apply Prettier to the Markdown files as well one of these days!)

@Elchi3
Copy link
Member

Elchi3 commented Jan 23, 2020

(That does remind me, though: we should certainly go through and apply Prettier to the Markdown files as well one of these days!)

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs ✍️ Issues or pull requests regarding the documentation of this project. schema ⚙️ Isses or pull requests regarding the JSON schema files used in this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The doc about what webview_android covers is confusing
3 participants