adding note about loadstart event firing async in Fx 79 onwards #6364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
data:api 🐇
ddbeck
reviewed
Jul 2, 2020
There was a problem hiding this comment.
Thanks for this PR, Chris.
Since the synchronous behavior is non-standard, I'd like to propose flipping this around a little. Something like:
- A plain
"version_added": "79" - A
"version_added": truewith"partial_implementation": trueand a note saying that the event dispatched synchronously (perhaps describing it as non-standard or unlike other browsers).
What do you think?
|
@ddbeck Yup, I agree with you; updated! |
ddbeck
requested changes
Jul 2, 2020
api/FileReader.json
Outdated
| }, | ||
| "firefox": [ | ||
| { | ||
| "version_added": true, |
There was a problem hiding this comment.
Ugh, sorry I forgot a couple things in my original comment. First, this is removed:
Suggested change
| "version_added": true, | |
| "version_removed": "79", |
api/FileReader.json
Outdated
| "notes": "<code>loadstart</code> event originally dispatched synchronously (should be asynchronously as per spec)." | ||
| }, | ||
| { | ||
| "version_added": "79" |
There was a problem hiding this comment.
And this entry should be before the other
api/FileReader.json
Outdated
| { | ||
| "version_added": true, | ||
| "partial_implementation": true, | ||
| "notes": "<code>loadstart</code> event originally dispatched synchronously (should be asynchronously as per spec)." |
There was a problem hiding this comment.
Minor tense thing here
Suggested change
| "notes": "<code>loadstart</code> event originally dispatched synchronously (should be asynchronously as per spec)." | |
| "notes": "<code>loadstart</code> event dispatches synchronously (should be asynchronously as per spec)." |
|
@ddbeck How now brown cow? ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://bugzilla.mozilla.org/show_bug.cgi?id=1502403