Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set experimental to false for wasm shared memory #6384

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Set experimental to false for wasm shared memory #6384

merged 2 commits into from
Jul 8, 2020

Conversation

chrisdavidmills
Copy link
Collaborator

@chrisdavidmills chrisdavidmills commented Jul 8, 2020

As per https://bugzilla.mozilla.org/show_bug.cgi?id=1648685

Looks like this was actually enabled in Firefox 79.

I also put experimental as false, as this is now enabled in multiple browsers (and firefox has its sharedarraybuffer story sorted out for 79)

@ghost ghost added the data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Jul 8, 2020
@Elchi3
Copy link
Member

Elchi3 commented Jul 8, 2020

In mdn/sprints#2219 (comment) @annevk said for Firefox 78:

WebAssembly.Memory now supports shared: true in its constructor. (This can be used to get an instance of the SharedArrayBuffer constructor.)

Anne, did that really ship in 78, or is it shipping in 79 now, per https://bugzilla.mozilla.org/show_bug.cgi?id=1648685?

@annevk
Copy link

annevk commented Jul 8, 2020

I'm pretty sure that shipped in 78. You can test with new WebAssembly.Memory({ shared:true, initial:0, maximum:0 }).buffer.constructor.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was actually enabled in Firefox 79.

It was already in 78. Please leave this alone :)

I also put experimental as false, as this is now enabled in multiple browsers (and firefox has its sharedarraybuffer story sorted out for 79)

okay, lets make this change here then, at least.

@chrisdavidmills
Copy link
Collaborator Author

OK, OK, back to 78 it goes ;-)

@Elchi3 Elchi3 changed the title updating firefox support for shared memory Set experimental to false for wasm shared memory Jul 8, 2020
@Elchi3 Elchi3 merged commit ad8302c into mdn:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants