Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burndown list: all changes from npm run confluence #6526

Closed
wants to merge 75 commits into from

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Aug 18, 2020

This branch/PR is in support of #6435 and not intended to be merged. Rather, I will use it as a burndown list of what changes are suggested by Confluence, to make sure we get the remaining value out of the data. I will split out PRs or revert changes on the branch until no changes remain and then close this PR.

@ghost
Copy link

ghost commented Aug 18, 2020

🤖 Note: This PR contains 300 or more files. Some automatic labels may not have been applied.

@ghost ghost added data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript dependencies ⛓️ Pull requests that update a dependency package or file. infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project labels Aug 18, 2020
@foolip
Copy link
Collaborator Author

foolip commented Aug 18, 2020

#6528 is the first PR I extracted from this. Confluence was correct, but a lot more checking and fixing was needed.

@foolip foolip force-pushed the run-confluence branch 2 times, most recently from e07788a to ef0a0cf Compare August 19, 2020 10:39
foolip added a commit to foolip/browser-compat-data that referenced this pull request Aug 19, 2020
Extracted from mdn#6526

https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=8359 was
tested in Chrome 35-44 and Opera 22-31 on Windows 8.1 on BrowserStack
to confirm, and the mobile browser data was mirrored.
queengooborg pushed a commit that referenced this pull request Aug 19, 2020
Extracted from #6526

https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=8359 was
tested in Chrome 35-44 and Opera 22-31 on Windows 8.1 on BrowserStack
to confirm, and the mobile browser data was mirrored.
@foolip foolip force-pushed the run-confluence branch 3 times, most recently from efeb8c9 to 85a4ea6 Compare August 21, 2020 11:31
@foolip
Copy link
Collaborator Author

foolip commented Aug 26, 2020

I've rerun after #6555 and pushed those results. There are lots of system errors still, so I've fixed those and released mdn-confluence 2.1.0. That will get rid of all the system problems I'd previously handled by reverting some changes on the branch.

queengooborg pushed a commit that referenced this pull request Aug 3, 2022
queengooborg pushed a commit that referenced this pull request Aug 3, 2022
)

The original data is from wiki migration:
#1248

The commit implementing the stop() method is here:
https://chromium.googlesource.com/chromium/src/+/ffbe9abb72c71abaf8623c56c9ad7f6ee04f48b4

That suggests Chrome 31 by naive date mapping.

But Chrome 32 was confirmed by evaluating
`MediaStreamTrack.prototype.stop` on Chrome 31 and 32 on BrowserStack.

Part of #6526.
foolip added a commit to foolip/browser-compat-data that referenced this pull request Aug 3, 2022
These changes are suggested by Web Confluence:
mdn#6526.

Exactly the same features are changed to ≤13 by the collector,
where Edge 12 results aren't available:
mdn#17224

For a bunch of these, there was also support in IE 10, and in those
cases Edge 14 is very implausible.
queengooborg pushed a commit that referenced this pull request Aug 3, 2022
These changes are suggested by Web Confluence:
#6526.

Exactly the same features are changed to ≤13 by the collector,
where Edge 12 results aren't available:
#17224

For a bunch of these, there was also support in IE 10, and in those
cases Edge 14 is very implausible.
queengooborg pushed a commit that referenced this pull request Aug 3, 2022
foolip added a commit to foolip/browser-compat-data that referenced this pull request Aug 4, 2022
This was implemented in Firefox 43:
https://bugzilla.mozilla.org/show_bug.cgi?id=912342

The same change is also made by mdn-bcd-collector:
mdn#17224

This reverts what appears to be a mistaken edit while updating Chrome
which was probably intended to update the Opera data:
mdn#1746

And now actually mirror the Opera data.

Part of mdn#6526.
foolip added a commit to foolip/browser-compat-data that referenced this pull request Aug 4, 2022
foolip added a commit to foolip/browser-compat-data that referenced this pull request Aug 4, 2022
These methods were both first exposed when ImageCapture shipped:
https://storage.googleapis.com/chromium-find-releases-static/44e.html#44e0ad0c40c920ab5259514c5ea262c8bd7cd5a5

So it was not full support from the start, but this would be better
captured as subfeatures for parameter support, if anyone would still be
interested in these details so long after.

Both confluence and collector suggest these exact changes:
mdn#6526
mdn#17224
@foolip
Copy link
Collaborator Author

foolip commented Aug 4, 2022

So, contrary to what I said, I went ahead and burned down this whole set of changes. There are PRs merged or open for everything now.

@foolip foolip closed this Aug 4, 2022
@foolip foolip deleted the run-confluence branch August 4, 2022 12:00
queengooborg pushed a commit that referenced this pull request Aug 9, 2022
…s() (#17253)

These methods were both first exposed when ImageCapture shipped:
https://storage.googleapis.com/chromium-find-releases-static/44e.html#44e0ad0c40c920ab5259514c5ea262c8bd7cd5a5

So it was not full support from the start, but this would be better
captured as subfeatures for parameter support, if anyone would still be
interested in these details so long after.

Both confluence and collector suggest these exact changes:
#6526
#17224
queengooborg pushed a commit that referenced this pull request Aug 9, 2022
queengooborg pushed a commit that referenced this pull request Aug 9, 2022
This was implemented in Firefox 43:
https://bugzilla.mozilla.org/show_bug.cgi?id=912342

The same change is also made by mdn-bcd-collector:
#17224

This reverts what appears to be a mistaken edit while updating Chrome
which was probably intended to update the Opera data:
#1746

And now actually mirror the Opera data.

Part of #6526.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript dependencies ⛓️ Pull requests that update a dependency package or file. infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants