Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom host #2298

Open
Ryuno-Ki opened this issue Dec 31, 2020 · 2 comments · May be fixed by #11394
Open

Allow for custom host #2298

Ryuno-Ki opened this issue Dec 31, 2020 · 2 comments · May be fixed by #11394
Labels
accepting PR We invite you to open a PR to resolve this issue. dx developer experience effort: small This task is a small effort. 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. idle p3 We don't have visibility when this will be addressed. 🚉 platform keeping the platform healthy

Comments

@Ryuno-Ki
Copy link

Allow to define a host (according to Express.js documentation this would be the second argument to

app.listen(PORT, () => {

) so a local instance could be checked from other devices on the same network, by passing in 0.0.0.0.
Useful when testing with a mobile (resp. the screenreader there, in my case).

@peterbe
Copy link
Contributor

peterbe commented Jan 7, 2021

Doesn't Expression already listen to some default environment variables? Can you find out?

@Ryuno-Ki
Copy link
Author

It does. NODE_ENV for production environments and DEBUG for trouble shooting.

Searching through the codebase, I can't spot further environment variables (except in testing or benchmarking scenarios).

@schalkneethling schalkneethling added the 🚉 platform keeping the platform healthy label Nov 3, 2021
@github-actions github-actions bot added the 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. label Dec 10, 2021
@caugner caugner added p4 Not urgent, only if time allows accepting PR We invite you to open a PR to resolve this issue. dx developer experience labels Nov 30, 2022
@github-actions github-actions bot added the idle label Dec 30, 2022
@caugner caugner added p3 We don't have visibility when this will be addressed. effort: small This task is a small effort. and removed p4 Not urgent, only if time allows labels Jun 24, 2024
@github-actions github-actions bot removed the idle label Jun 25, 2024
@caugner caugner linked a pull request Jul 1, 2024 that will close this issue
@github-actions github-actions bot added the idle label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PR We invite you to open a PR to resolve this issue. dx developer experience effort: small This task is a small effort. 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. idle p3 We don't have visibility when this will be addressed. 🚉 platform keeping the platform healthy
Projects
Development

Successfully merging a pull request may close this issue.

4 participants