Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notion Data Connector #8

Closed
nickscamara opened this issue Jan 30, 2024 · 15 comments · Fixed by #10
Closed

Add Notion Data Connector #8

nickscamara opened this issue Jan 30, 2024 · 15 comments · Fixed by #10

Comments

@nickscamara
Copy link
Member

Add a Notion data connector that grabs all the content from all the pages in the authorized workspaces. That means it needs to attempt to get all the contents inside all nested databases in notion etc. Should authorize with nango etc, following the github/google drive implementations.

This should help implement the getDocuments function: https://github.com/NangoHQ/nango/blob/master/integration-templates/notion/notion-pages.ts

Other requirements:

  • Make sure to add proper tests inside the tests folder
  • If an added env is required, please update the env.example

https://docs.nango.dev/integrations/all/notion

DO NOT START WORKING ON THIS BEFORE GETTING ASSIGNED, OTHERWISE WE CAN'T AWARD THE BOUNTY

@nickscamara
Copy link
Member Author

@mogery wanna work on this? If so, I create a bounty and assign you to it.

@mogery
Copy link
Contributor

mogery commented Jan 30, 2024

Hell yeah!

@nickscamara
Copy link
Member Author

/bounty $35

Copy link

algora-pbc bot commented Jan 30, 2024

💎 $35 bounty created by mendableai
🙋 If you'd like to work on this issue, comment below to get assigned
👉 To claim this bounty, submit a pull request that includes the text /claim #8 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
~~🙏 Thank you for contributing to mendableai/data-connectors! ~~

👉 Add a bountyShare on socials

DO NOT START WORKING ON THIS BEFORE GETTING ASSIGNED, OTHERWISE WE CAN'T AWARD THE BOUNTY
Other attempts will be allowed if the user assigned does not open a PR within 48 hours.

@nickscamara
Copy link
Member Author

nickscamara commented Jan 30, 2024

Awesome! Assigned to you! @mogery

@mogery
Copy link
Contributor

mogery commented Jan 30, 2024

@nickscamara What format should the pages be returned in? Is JSON fine, should I convert everything to markdown for easy parsing, or perhaps just dump out all the text?

@nickscamara
Copy link
Member Author

You can just dump all the raw text into content .

@nickscamara
Copy link
Member Author

@mogery Actually, if converting to markdown is easy and won't take too much time, that would be great

@mogery
Copy link
Contributor

mogery commented Jan 30, 2024

Due to API limitations, only Notion pages that have been connected with the integration (and their children) will be available to the data connector. I've recorded a GIF on how to do this: my integration in this example is called "mendable test".

ScreenRecording2024-01-30at21 20 00-ezgif com-video-to-gif-converter

@nickscamara
Copy link
Member Author

@mogery sounds good. Would the child page of that page be accessible if you add a connection to the parent page? Also, does the same apply to databases? Thank you :)

@mogery
Copy link
Contributor

mogery commented Jan 30, 2024

@mogery sounds good. Would the child page of that page be accessible if you add a connection to the parent page? Also, does the same apply to databases? Thank you :)

Yup, access travels down the parent-child tree. Checking for databases now.

@mogery
Copy link
Contributor

mogery commented Jan 30, 2024

Yeah, access also travels to databases, and nested pages are automatically included in the list query :) Opening PR...

Screenshot 2024-01-30 at 21 31 55

@nickscamara
Copy link
Member Author

Awesome!!! @mogery

Copy link

algora-pbc bot commented Jan 30, 2024

💡 @mogery submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Copy link

algora-pbc bot commented Jan 30, 2024

🎉🎈 @mogery has been awarded $35! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants