-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis should support ES6 #815
Comments
Setting node to 8.x gives the following error when running on travis
So the fix is not as trivial as I thought. Any insights as to what is going on @wlach? |
Hmm, the version of node you're specifying in that change looks weird. Could you try to specify the node version as done here: Also, in the future when you're working on something like this, just go ahead and make the pull request (even if it's "broken") -- it'll be easier for me to find the changes and avoids the overhead of having a separate issue. :) |
I think we're good here, thanks @lobax and co.! |
As a part of #807 and #811, we need to be able to test the modern ES6 constructs. These will however currently fail on travis, given that travis is configured to run on Node.js 0.10 (which does not support ES6 constructs).
Proposed solution: Travis should be configured to run on a newer version of Node that supports ES6 (e.g. 8.x)
The text was updated successfully, but these errors were encountered: