Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin migrating test framework to Jest #845

Open
hamilton opened this issue Apr 5, 2018 · 0 comments
Open

Begin migrating test framework to Jest #845

hamilton opened this issue Apr 5, 2018 · 0 comments

Comments

@hamilton
Copy link
Collaborator

hamilton commented Apr 5, 2018

This is part of #807. Metrics Graphics is a really large library, and one that is largely tested visually. Total nightmare. Refactoring and pushing toward more testable, cleaner code (#811) requires refactoring to deal with smaller code chunks, removing side effects, and thoroughly writing tests around the smaller quantities.

The first step should be straightforward - let's set up a jest-test script for now (so it doesn't clash with the current test script) and begin migrating out the tests into that, refactoring as we go. We can begin populating a jest-test directory until we feel we have comparably bleak coverage, and then replace qunit altogether.

@wlach if this sounds good to you I can make a PR that accomplishes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant