-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support build tags #230
Comments
Thanks for sharing this feature request! I see there's a request in golint as well golang/lint#358. I'm traveling in the next few weeks; will try to look at the feature after that. I see two ways to approach this:
From what I understand, in both cases the tags should be retrieved from the values of environment variables? |
I don't know of any environment variables. golangci-lint has a |
Did some research and it looks like the difference is that In October I'll have time to look at it. So far the ideal solution seems to be extension of |
@mgechev i just migrated our monorepo from golint to revive (because i couldn't get myself to debug another false-positive for golint, doesn't make sense that we maintain it internally if it is deprecated). We have build tags and test packages implemented over go/loader for golint. I think the only thing that is missing is CGo support but we have that implement with our internal static analysis. I don't know if go/loader is still an option these days but if you want to do a session with me looking through the code give me a ping. |
@chavacava might be a better person to have a look at the code with you. I've been mostly focused on TypeScript nowadays. |
In order to lint all files, the linter needs to be able to use build tags. It will actually fail to run if all the files in a directory have build tags.
The text was updated successfully, but these errors were encountered: