Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getVariant/TargetingFilter might accept any context type #20

Open
Eskibear opened this issue Aug 16, 2024 · 1 comment
Open

getVariant/TargetingFilter might accept any context type #20

Eskibear opened this issue Aug 16, 2024 · 1 comment

Comments

@Eskibear
Copy link
Member

          We're actively debating this now- but I think context here should be unknown. https://github.com/microsoft/FeatureManagement-Dotnet/pull/484/files#r1717629098

Originally posted by @rossgrambo in #13 (comment)

@Eskibear
Copy link
Member Author

Given the possibility that we calculate audience context id based on any other property rather than userid, I agree that the context can be unknown (or to limit it to an object?).
A good thing is, here all properties in ITargetingContext are optional, meaning it’s compatible with an arbitrary object type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant