Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piecewise linear trees #1315

Closed
sosmond opened this issue Apr 16, 2018 · 7 comments
Closed

Piecewise linear trees #1315

sosmond opened this issue Apr 16, 2018 · 7 comments

Comments

@sosmond
Copy link

sosmond commented Apr 16, 2018

I recently discovered this paper which was submitted earlier this year showing impressive results of GBDTs utilizing piecewise linear trees. It's claimed that PL trees converge faster and are more accurate than the constant trees xgboost & lightgbm uses, and that optimizations exist to make GBDT-PL competitive speed-wise.

The repo for the paper can be found here. Is there any chance of adding this feature?

@StrikerRUS
Copy link
Collaborator

Closed in favor of being in #2302. We decided to keep all feature requests in one place.

Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature.

@kruda
Copy link
Contributor

kruda commented Feb 22, 2020

I'd like to work on this issue.

@jameslamb
Copy link
Collaborator

Thanks @kruda ! I'll re-open and assign to you. Let us know if you have any questions.

@StrikerRUS
Copy link
Collaborator

@jameslamb I believe we should re-open a feature request issue only after any evidence of active work on it. Otherwise, we may fall down into dozens of open stale issues like it was before #2302, e.g. here #261 (comment).

@kruda You can submit a PR any time you want marking it [WIP] so that it will be easier to discuss implementation aspects and ask related questions.

@jameslamb
Copy link
Collaborator

@jameslamb I believe we should re-open a feature request issue only after any evidence of active work on it. Otherwise, we may fall down into dozens of open stale issues like it was before #2302, e.g. here #261 (comment).

@kruda You can submit a PR any time you want marking it [WIP] so that it will be easier to discuss implementation aspects and ask related questions.

ok fair enough!

@stanpcf
Copy link

stanpcf commented Apr 2, 2020

Hi @kruda How is your process going?

@StrikerRUS
Copy link
Collaborator

Implemented in #3299.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants