Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] Add additional linters to CI #2477

Closed
jameslamb opened this issue Sep 29, 2019 · 4 comments
Closed

[R-package] Add additional linters to CI #2477

jameslamb opened this issue Sep 29, 2019 · 4 comments

Comments

@jameslamb
Copy link
Collaborator

Linting for the R code in this project was introduced in #2437 . As of that PR, the following linters from the lintr project were not available from the distribution of lintr on CRAN.

github_only_linters <- list(
    "equals_na" = lintr::equals_na_linter
    , "function_left" = lintr::function_left_parentheses_linter
    , "implicit_integers" = lintr::implicit_integer_linter
    , "paren_brace_linter" = lintr::paren_brace_linter
    , "semiconlon" = lintr::semicolon_terminator_linter
    , "seq" = lintr::seq_linter
    , "todo_comments" = lintr::todo_comment_linter
    , "true_false" = lintr::T_and_F_symbol_linter
)

To close this issue, add those linters to .ci/lint_r_code.R once lintr does a new release (> 1.0.3) to CRAN.

@jameslamb
Copy link
Collaborator Author

Closing in favor of being in #2302 with other feature requests. If you'd like to submit a PR to address this, re-open the issue.

@jameslamb
Copy link
Collaborator Author

Since we use r-lintr distribution from conda (not CRAN), to complete this issue it may also be necessary to make a pull request to https://github.com/conda-forge/r-lintr-feedstock to get r-lintr feedstock updated.

@jameslamb
Copy link
Collaborator Author

it seems that lintr did a release on October 1, 2019! I am going to re-open this issue and pick it up tonight or tomorrow.

@jameslamb jameslamb reopened this Oct 28, 2019
@jameslamb jameslamb self-assigned this Oct 28, 2019
@jameslamb
Copy link
Collaborator Author

and they updated the conda feedstock for r-lintr 🙌

Seems that project has a bot that automatically opens a PR when a new version makes it to CRAN (or maybe when a new release is created on jimhester/lintr).

Either way, should be able to address this issue now!

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant