Quick fix all showing up even if there is only one error

[mjbvz]

Code

class Foo {
    prop: number

    foo() { prop }
}

Using VS Code insiders, trigger quick fix on prop in foo

Expected behavior:
Only a single code action is shown

Actual behavior:
The base code action and a quick fix all code action are shown. The latter doesn't make sense as there is only a single error in the file

@andy-ms Is this something we are supposed to handle on the VS Code side or should getCombinedCodeFix be smarter here?

[RyanCavanaugh]

Isn't this desirable? If you bound a key combination to Quick fix all, you wouldn't want it to not work when there was only 1 thing to do.

[mjbvz]

This is for our lightbulb context menu:

Having the extra entry doesn't make sense since there is only one error

[mhegazy]

This is something that should be handled on the IDE side. Ideally we do not want to require for all errors just to produce quick fixes (getting errors is expensive). A simple approximation here is if the diagnostic code has been reported only once in this file, then you can ignore the fixId, and not show the additional menu item.

[mjbvz]

Ok, I can make this change for VS Code 1.20. Just to make sure I understand: it is safe to assume that any diagnostic that only appears once in a file will not have a "fix all" action?

[ghost]

it is safe to assume that any diagnostic that only appears once in a file will not have a "fix all" action?

I think we will always provide a fix-all action, but the action would only end up fixing one thing (since there is only one diagnostic).
But there's also the problem that a diagnostic code may appear only once, but there may be other diagnostic codes that would be part of the same fix...