Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALM Accelerator - QUESTION] Why does the template deploy-Solution.yml take importUnmanaged parameter but rely on isUnmanaged variable? #9074

Open
mookmac opened this issue Oct 3, 2024 · 0 comments
Labels
alm-accelerator ALM Accelerator Components and Apps question Further information is requested

Comments

@mookmac
Copy link

mookmac commented Oct 3, 2024

What is your question?

In coe-alm-accelerator-templates:
Why does the template deploy-Solution.yml take importUnmanaged input parameter but rely on isUnmanaged variable to actually control the behaviour logic?

This is not only very confusing but also means that the deploy-Solution.yml template is tightly coupled to Pipelines/Templates/build-deploy-Solution-To-Environment-Common.yml or Pipelines/Templates/import-Solution-To-Dev-Environment.yml as these templates are the ones setting the isUnmanaged variable.

It seems to me that it would be more intuitive to make use of the input parameter importUnmanaged to control the logic in this template.

What component are you experiencing the issue with?

ALM Accelerator Pipelines

What solution version are you using?

latest version of main branch as of October 2024.

@mookmac mookmac added alm-accelerator ALM Accelerator Components and Apps question Further information is requested labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alm-accelerator ALM Accelerator Components and Apps question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant