The objective C wrapper should support all LogConfiguration settings that v1 did

[kindbe]

Right now it only supports two, but teams like OneDrive and Outlook will need more.

[maxgolov]

Can you use this: https://developer.apple.com/documentation/foundation/nsjsonserialization to maybe transform from ILogConfiguration to a "A Foundation object"? I'm not very familiar with Obj-C. But it appears that you might be able to use JSON to marshal from ILogConfiguration to a Foundation object, then have a method LogManager::Configure bound to perform the marshaling of a Foundation object via JSON string, and re-configure the ILogConfiguration based on that. That's a bit costly, but since it's very infrequent operation (once) - we can measure how much it takes. It'd probably be less code than manually individually copying all fields and settings one by one.

I'm trying hard to remember how I did the code that transforms from populated ILogConfiguration into JSON (which was done to create JSON config files for ILogConfiguration in EventSender example). It was something to do with Variant to JSON code, maybe in Variant.hpp

[kindbe]

Looking at bringing parity with the v1 obj-c SDK, everything looks to have a 1DS counterpart except this:

/*!
@brief [optional] Cause user session events to be sent automatically.
*/
@Property (nonatomic, assign) BOOL enableAutoUserSession;

[maxgolov]

We do not currently support automatic session logging in 1DS SDK. I'm not sure about the exact logical reason why. Session Id should automatically allocated though, here:

// Initializer for Session Data object

cpp_client_telemetry/lib/api/LogManagerImpl.cpp

Line 168 in 9444ff2

m_logSessionData.reset(new LogSessionData(cacheFilePath));

// Getter for Session Data object
https://github.com/microsoft/cpp/_client_telemetry/blob/9444ff278acbcce2a0084ade429d4ce571ff7fe5/lib/api/LogManagerImpl.cpp#L626

Populated on ext.sdk.installId

record.extSdk[0].installId = m_owner.GetLogSessionData()->getSessionSDKUid();

We can add LogSession(...) API calls in Initialize and FlushAndTeardown at C++ layer if the flag is set. I think there were practical reasons why we could not generally assume that those are the rightful places: since ideally the OS may at any time put the app to sleep (without us knowing if it's gonna be resumed or not). For that matter it should probably be manually handled by the app in some form of OS-specific "onResuming" / "onSuspending" handler code? Basically the app calling LogSession(...) manually.

[maxgolov]

Just checking with you guys, if the iOS wrapper already supports all the options you need? Can this issue be closed?
Tagging folks working on Obj-C layer: @kindbe @eduardo-camacho @agavipul @kivarsha