Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar - "Go to Today" button doesn't do anything when on current month #6873

Closed
amygl opened this issue Oct 26, 2018 · 4 comments
Closed

Comments

@amygl
Copy link
Contributor

amygl commented Oct 26, 2018

Environment Information

Repro:
https://fabricweb.z5.web.core.windows.net/oufr/6.93.0/#/examples/calendar

Actual behavior:

If on a different month the "Go to Today" button will navigate calendar to current month. But if on the month that contains today, clicking the button will do nothing.

This came up during an accessibility test pass. Narrator announces the "Go to Today" as a button "but it is non-interactable, this will confuse users who are unable to select with the keyboard." Note, this is not being tracked as an accessibility bug, it is for usability.

Expected behavior:

The "Go to Today" button will be disabled or hidden on the current month.

Priorities and help requested:

Are you willing to submit a PR to fix? (Yes, No) No

Requested priority: (Blocking, High, Normal, Low) Normal

Products/sites affected: (if applicable) Planner

@JasonGore
Copy link
Member

This bug needs action but we need to determine whether the resolution is to disable or hide the button. Chatting with @lorejoh12 for the Calendar designers to determine whether the resolution is to hide or disable the button.

@dzearing
Copy link
Member

@JasonGore @lorejoh12 Looks like this bug fell off the radar; any updates here?

@lorejoh12
Copy link
Contributor

Sorry about that! We actually fixed this quite a while ago, looks like we forgot to link this bug to the PR.

commit: 6ec50ae #6938

@dzearing
Copy link
Member

dzearing commented Feb 1, 2019

Closing the issue; @amygl let us know if you run into this again. :)

@dzearing dzearing closed this as completed Feb 1, 2019
@microsoft microsoft deleted a comment from msft-github-bot Jun 12, 2019
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants