Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log filled with liveshare trace message #3007

Closed
aeschli opened this issue Nov 21, 2019 · 2 comments
Closed

Log filled with liveshare trace message #3007

aeschli opened this issue Nov 21, 2019 · 2 comments
Assignees

Comments

@aeschli
Copy link

aeschli commented Nov 21, 2019

VSCode Version: 1.41.0-insider
Commit: bf7d03bf88732af0b46e473c663c49e18e839f9c
Date: 2019-11-15T05:32:36.095Z
Electron: 6.1.4
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 4.15.0-66-generic

Liveshare 1.0.1293

  • Live share extension is installed, but I'm not logged in
  • Run command Set Log Level..., pick Verbose
  • Open the Output > Log (Extension Host) tab
  • Open a plain text filr like 'LICENCE`
  • Note that every second it logs 8 new lines:
[2019-11-21 09:18:50.925] [exthost] [trace] ExtHostCommands#executeCommand vscode.executeCodeLensProvider
[2019-11-21 09:18:50.925] [exthost] [trace] ExtHostCommands#executeCommand _executeCodeLensProvider
[2019-11-21 09:18:50.926] [exthost] [trace] [ms-vsliveshare.vsliveshare] INVOKE provider 'm'
[2019-11-21 09:18:50.926] [exthost] [trace] [ms-vsliveshare.vsliveshare] provider DONE after 0ms
  • I checked in the debugger and it is LiveShare that constantly calls vscode.executeCodeLensProvider

  • As I'm not logged in to LiveShare, I would expect that no providers are being registered by LiveShare, nor any work done.

  • As there are no modification in the editor, it's unclear to me why vscode.executeCodeLensProvider needs to be constantly called.

@setaskin
Copy link

setaskin commented Nov 21, 2019

Adding @daytonellwanger

@derekbekoe
Copy link
Collaborator

We’ve made improvements in this area since this issue was filed. Further, #4470 will remove the Live Share extension activation behavior that was mentioned above.

@derekbekoe derekbekoe closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants