Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Add a profile" should lead to its own page #9121

Closed
carlos-zamora opened this issue Feb 11, 2021 · 1 comment · Fixed by #9352
Closed

"Add a profile" should lead to its own page #9121

carlos-zamora opened this issue Feb 11, 2021 · 1 comment · Fixed by #9352
Assignees
@PankajBhojwani
Labels
Area-Settings UI Anything specific to the SUI Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.9

Comments

@carlos-zamora
Copy link
Member

Description of the new feature/enhancement

Currently, adding a profile in the Settings UI is a bit simplistic: click "add new" and you're taken to a new profile. "Add new" should be expanded to be its own page that can include the following:

Click here for a rough design.
@carlos-zamora carlos-zamora added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Area-Settings UI Anything specific to the SUI labels Feb 11, 2021
@carlos-zamora carlos-zamora added this to the Terminal v1.9 milestone Feb 11, 2021
@carlos-zamora carlos-zamora self-assigned this Feb 11, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 11, 2021
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 11, 2021
@carlos-zamora carlos-zamora mentioned this issue Feb 11, 2021
Open
25 tasks
@PankajBhojwani PankajBhojwani mentioned this issue Mar 3, 2021
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Mar 3, 2021
@ghost ghost closed this as completed in #9352 May 5, 2021
ghost pushed a commit that referenced this issue May 5, 2021
@PankajBhojwani
Create a new page for "Add new profile" in the SUI (#9352)
b53bd67 
- Whenever we add a new profile setting from now on we have to update
  `Profile::CopySettings` _and_ `CascadiaSettings::DuplicateProfile` 👎 

Notes from bug bash (checked bugs have been resolved):

- [ ] The duplicate list can be very long if you have profiles
- [x] DH: "Create new" seems too vague. "New empty profile" or something
  seems a little clearer to me.
- [x] There is no deduplication counter for name
- [x] Crash when your settings file is corrupt and we had to fall back
  to the defaults and you duplicate a profile
- [x] Crash due to #10003

## PR Checklist
* [x] Closes #9121
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels May 5, 2021
@ghost
Copy link

ghost commented May 25, 2021

🎉This issue was addressed in #9352, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-Settings UI Anything specific to the SUI Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.9
Development

Successfully merging a pull request may close this issue.

Create a new page for "Add new profile" in the SUI microsoft/terminal
2 participants
@carlos-zamora @PankajBhojwani