Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement JSON serialization for models #3330

Closed
Tracked by #3329
ArcturusZhang opened this issue May 13, 2024 · 0 comments · Fixed by #3749
Closed
Tracked by #3329

Implement JSON serialization for models #3330

ArcturusZhang opened this issue May 13, 2024 · 0 comments · Fixed by #3749
Assignees
@jorgerangel-msft
Labels
emitter:client:csharp

Comments

@ArcturusZhang
Copy link
Member

ArcturusZhang commented May 13, 2024 •
edited by jorgerangel-msft
Loading

This task is a follow up to
Azure/autorest.csharp#4476 and covers implementing the method bodies for json serialization methods.
@ArcturusZhang ArcturusZhang mentioned this issue May 13, 2024
Open
@timotheeguerin timotheeguerin changed the title [http-client-csharp] Implement JSON serialization for models Implement JSON serialization for models May 13, 2024
@jorgerangel-msft jorgerangel-msft self-assigned this May 21, 2024
@jorgerangel-msft jorgerangel-msft mentioned this issue Jun 17, 2024
Closed
This was linked to pull requests Jun 19, 2024
Fix Indentation in several statements #3622
Merged
Add snippets for SCM model serialization #3634
Merged
@jorgerangel-msft jorgerangel-msft linked a pull request Jun 21, 2024 that will close this issue
Remove singleton pattern from providers #3642
Merged
@jorgerangel-msft jorgerangel-msft mentioned this issue Jun 24, 2024
Merged
This was unlinked from pull requests Jun 24, 2024
Add snippets for SCM model serialization #3634
Merged
Remove singleton pattern from providers #3642
Merged
This was referenced Jun 24, 2024
Merged
Merged
@jorgerangel-msft jorgerangel-msft removed a link to a pull request Jun 24, 2024
Fix Indentation in several statements #3622
Merged
@jorgerangel-msft jorgerangel-msft mentioned this issue Jun 24, 2024
Closed
github-merge-queue bot pushed a commit that referenced this issue Jun 25, 2024
@jorgerangel-msft
Remove singleton pattern from providers (#3642)
ab5b962 
This PR removes the singleton pattern from all type providers to allow
users to optionally override their implementation from their library.

Supports #3330
github-merge-queue bot pushed a commit that referenced this issue Jun 26, 2024
@jorgerangel-msft
Add snippets for SCM model serialization (#3634)
367fa13 
This PR decouples the snippet related changes from
#3603 that were added to
support model serialization generation. It extends the implementation of
`OptionalProvider` by overriding the base library and replacing it's
instance type with the `SystemOptionalProvider` which generates an
additional method in the SCM plugin.

Supports #3330
@jorgerangel-msft jorgerangel-msft mentioned this issue Jun 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 26, 2024
@jorgerangel-msft
Support Generating Json Model Serialization Write Method (#3667)
b996ba6 
This PR decouples the changes from
#3603 to support generating
the json model serialization write method for a model.


Supports #3330.
This was referenced Jun 27, 2024
Merged
Merged
@m-nash m-nash mentioned this issue Jun 28, 2024
Closed
@jorgerangel-msft jorgerangel-msft mentioned this issue Jul 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 1, 2024
@jorgerangel-msft
Add PersistableModel serialization method (#3711)
308f96f 
This PR decouples the changes from
#3603 to support generating
the PersistableModel serialization method.

Supports #3330.
@jorgerangel-msft jorgerangel-msft mentioned this issue Jul 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 1, 2024
@jorgerangel-msft
Generate GetFormatFromOptions struct override (#3714)
72e26ac 
This PR adds support for generating the `GetFormatFromOptions` method
override for models that are structs.

Supports #3330.
@jorgerangel-msft jorgerangel-msft mentioned this issue Jul 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 2, 2024
@jorgerangel-msft
Generate deserialize model method (#3683)
970091a 
This PR decouples the changes from
#3603 to support generating
the deserialization method for a model.

Supports #3330.
@jorgerangel-msft jorgerangel-msft mentioned this issue Jul 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 2, 2024
@jorgerangel-msft
Generate PersistableModel create method (#3722)
47c93c8 
This PR decouples the changes from
#3603 to support generating
the PersistableModel Create serialization method.

Supports #3330.
github-merge-queue bot pushed a commit that referenced this issue Jul 3, 2024
@jorgerangel-msft
Add JsonModel Create method implementation (#3734)
81a2729 
This PR adds support for generating the JsonModel Create serialization
method.

Supports #3330.
@jorgerangel-msft jorgerangel-msft linked a pull request Jul 3, 2024 that will close this issue
Add serialization functional tests #3749
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgerangel-msft jorgerangel-msft

Labels
emitter:client:csharp
Projects
None yet
Milestone
No milestone
3 participants
@timotheeguerin @ArcturusZhang @jorgerangel-msft