-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify remote kernel finder with ServerUriStorage #11645
Comments
Yeah, the current usage of ServerUriStorage is hacky given how I use it from the new experimental picker. I'm actually kinda intrigued on a concept like the ContributedKernelFinder moving up into the UI layer. From the perspective of the picker I wouldn't want to have to care about the difference between server / local / whatever. All that really matters is there is some thing X that provides kernels. Maybe a UriStorage isn't needed at all? Instead we are just working with a list of KernelSources some are local, or remote, or third party, ect... If something is added to the list it can control its own registration for kernel finding. So you could do something like an extensibility point that let you add kernels directly from another extension, instead of adding servers. |
We can consider moving off |
|
With the introduction of the new remote finder and server picker experience, we might want to revisit how we are registering kernels from remote uris and what we store in
ServerUriStorage
ServerUriStorage
can contain following infolocal
when users explicitly set the server toNone
from the server pickercurrentServerId
referring to the currently picked entrylocalOnly
referring to if we should connect to local only (❓)LocalKernelFinder
contributes all local kernelsRemoteKernelFinder
checksServerUriStorage#currentServerId
and decides if/how to detect kernel specs/sessionsServerUriStorage
islocal
, then it doesn't attempt to scan kernel specs/sessions.UniversalRemoteKernelFinderController
creates aUniRemoteKernelFinder
for all entriesUniRemoteKernelFinder
follows the same logic asRemoteKernelFinder
, if itsuri
islocal
, it contributes empty kernel specs/sessions.It would be great if we can move
local
out of theServerUriStorage
and we can simply theRemoteKernelFinder
ctor and registrations intoServerUriStorage
only holds server uri infoscurrentSelectedUri
infocurrentSelectedUri
updateServerUriStorage#getUris
cc @IanMatthewHuff @DonJayamanne
The text was updated successfully, but these errors were encountered: