Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell Tags view showing up in explorer #12321

Closed
Tyriar opened this issue Nov 10, 2022 · 8 comments
Closed

Cell Tags view showing up in explorer #12321

Tyriar opened this issue Nov 10, 2022 · 8 comments
Assignees
Labels
debt Code quality issues under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 10, 2022

I opened the vscode repo this morning and saw this:

image

Pretty sure I didn't move that view from somewhere else and I haven't interacted with notebooks in a while.

@rebornix rebornix added the under-discussion Issue is under discussion for relevance, priority, approach label Nov 10, 2022
@rebornix
Copy link
Member

@sbatten aware of any change recently for views? This custom view was shipped via Jupyter extension pack for more than 2 months and its default position is Jupyter view container (shipped in the same extension pack). I haven't seen bug reports of it being placed wrong until this one.

@Tyriar
Copy link
Member Author

Tyriar commented Nov 10, 2022

Jupyter isn't enabled for some reason, I don't know why:

image

This is a local workspace

@sbatten
Copy link
Member

sbatten commented Nov 10, 2022

@Tyriar does the view context menu show "Reset Location"?

Also, if you export your current profile, the UI state should be saved in it so I can take a look at that.

@Tyriar
Copy link
Member Author

Tyriar commented Nov 10, 2022

@sbatten see my previous comment, I think the problem is that the jupyter view doesn't exist, so it defaults to expanded in the explorer view (which kind of sucks, but this isn't meant to happen).

@sbatten
Copy link
Member

sbatten commented Nov 10, 2022

can you look at the full extension pack and see what is enabled/disabled

@rebornix
Copy link
Member

This explains what we are seeing, Jupyter Cell Tags contributes view to the Jupyter view container, which should come from the Jupyter extension but it's disabled. Also we didn't enforce extension dependency on Jupyter Cell Tags (since it can work well with ipynb extension)

@sbatten
Copy link
Member

sbatten commented Nov 10, 2022

I can repro by disabling the extension pack and manually enabling the cell tags extension. I'm certain this is the long standing behavior of view contributions though. They always fallback to the explorer.

@rebornix rebornix transferred this issue from microsoft/vscode Dec 5, 2022
@sbatten sbatten removed their assignment Dec 5, 2022
@rebornix rebornix added the debt Code quality issues label Dec 12, 2022
@rebornix rebornix added this to the January 2023 milestone Dec 12, 2022
@rebornix rebornix modified the milestones: January 2023, February 2023 Jan 25, 2023
@rebornix
Copy link
Member

Fixed via microsoft/vscode-jupyter-cell-tags#22.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants