Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write automated tests to test and ensure expected performance characteristics #7437

Closed
greazer opened this issue Sep 7, 2021 · 1 comment · Fixed by #10025
Closed

Write automated tests to test and ensure expected performance characteristics #7437

greazer opened this issue Sep 7, 2021 · 1 comment · Fixed by #10025
Assignees
Labels
debt Code quality issues perf Performance issues

Comments

@greazer
Copy link
Member

greazer commented Sep 7, 2021

No description provided.

@amunger
Copy link
Contributor

amunger commented Mar 30, 2022

Breakdown of the work involved:

  • Select an initial test that represents a basic perf scenario.
    • Modify the test to measure specific checkpoints. Some already exist, like extension activation time.
  • Update the existing perf-test.yml to run the initial test. (https://github.com/microsoft/vscode-jupyter/blob/main/.github/workflows/perf-test.yml)
  • Publish the timing data to Kusto and GH actions summary(ensure the telemetry is reaching Kusto from CI pipeline runs.)
    • Kusto for historical trends and GH actions summary for immediate results validation.
    • Add dimensions to the telemetry so we can tie data back to specific commits.
  • Run the workflow several times to measure the variance that we experience without any changes.
  • Set the workflow trigger to run on PRs to main.

@amunger amunger self-assigned this May 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues perf Performance issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants