Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default and/or suggest environment for new notebooks #9115

Closed
greazer opened this issue Feb 24, 2022 · 2 comments
Closed

Default and/or suggest environment for new notebooks #9115

greazer opened this issue Feb 24, 2022 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-getting-started papercut 🩸 Something affecting the productivity of the team

Comments

@greazer
Copy link
Member

greazer commented Feb 24, 2022

Suggestion 1 (previously selected kernel)

Pulled from issue #8530

From @abatomunkuev

Hello!

I think it would be great to change it to the environment that was previously used by the user and mark it as suggested so that the user doesn't have to specify the environment again.

Maybe for the initial start (very first start), we can ask the user: "what environment would you like to choose". Once the user selects the environment, we can mark it as suggested. From there, every time user creates a new notebook, the environment will belong to the one that the user has chosen previously (marked as "suggested").

Suggestion 2

If a conda environment is activated in the temrinal, and we launch VS Code from the terminal,
then pre-select the corresponding conda environment in new Notebooks.

Questions

  • Notebooks
    • These new rules could conflict with the active Python interpreter. Assume your active interpreter is PythonA, and based on Suggestion 1/2, the new kernel is CondaA. Would this confuse the user?
  • Interactive Window
    • Assume your active interpreter is PythonA, and based on Suggestion 1/2, the new kernel is CondaA.
    • Now user runs a cell against IW (via code cells in a *.py file), what would they expect?
    • I'd always expect the kernel to point to the active interpreter

@DonJayamanne what do you think?

@greazer greazer added bug Issue identified by VS Code Team member as probable bug enhancement papercut 🩸 Something affecting the productivity of the team labels Feb 24, 2022
@DonJayamanne
Copy link
Contributor

will have alook at the vsc api to see if we can do something with the existing stuff.

@greazer greazer added this to the March 2022 milestone Feb 24, 2022
@DonJayamanne DonJayamanne changed the title Default and/or suggest previously used environment for new notebooks Default and/or suggest environment for new notebooks Mar 17, 2022
@rchiodo rchiodo modified the milestones: March 2022, April 2022 Mar 23, 2022
@rchiodo rchiodo modified the milestones: April 2022, May 2022 Apr 27, 2022
@rchiodo rchiodo modified the milestones: May 2022, June 2022 Jun 1, 2022
@rchiodo rchiodo removed their assignment Jul 1, 2022
@rchiodo rchiodo modified the milestones: June 2022, July 2022 Jul 1, 2022
@greazer greazer removed this from the July 2022 milestone Jul 8, 2022
@DonJayamanne
Copy link
Contributor

Closing this as we've decided not to have any sugegstions for new notebooks as the algorithm will never be accurate
Solution: If we're 100% certain about the kernel, then suggest something, else let the user pick one from the kernelpicker

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-getting-started papercut 🩸 Something affecting the productivity of the team
Projects
None yet
Development

No branches or pull requests

4 participants