Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code for node specific and web specific #9627

Closed
rchiodo opened this issue Apr 7, 2022 · 1 comment
Closed

Refactor code for node specific and web specific #9627

rchiodo opened this issue Apr 7, 2022 · 1 comment
Labels
triage-needed Issue needs to be triaged

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Apr 7, 2022

3 Ideas for web refactor:

  • VS Code style - each folder has a 'common', 'browser', and a 'node' folder. Subfolders can have them too.
  • Extension - each file indicates whether or not it's browser/node/both with extensions like '.node.ts', '.web.ts' and '.ts'
  • Root folders - we have root folders that are 'common', 'browser', and 'node'. Other folders are mirrored in these subfolders
@rchiodo rchiodo added bug Issue identified by VS Code Team member as probable bug engineering and removed bug Issue identified by VS Code Team member as probable bug labels Apr 7, 2022
@rchiodo
Copy link
Contributor Author

rchiodo commented Apr 7, 2022

We voted and picked the 2nd one.

@rchiodo rchiodo closed this as completed Apr 7, 2022
@chrisdias chrisdias mentioned this issue Apr 11, 2022
Closed
15 tasks
@greazer greazer added triage-needed Issue needs to be triaged and removed needs-triage labels May 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
triage-needed Issue needs to be triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greazer @rchiodo