From d115600532b38dd645fec5464a04e743db932dd8 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Mon, 26 Jul 2021 14:24:01 -0700 Subject: [PATCH] Ensure skipped status is set on unittest tests --- src/client/testing/testController/unittest/runner.ts | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/client/testing/testController/unittest/runner.ts b/src/client/testing/testController/unittest/runner.ts index c54adac34f819..82cfa140178e2 100644 --- a/src/client/testing/testController/unittest/runner.ts +++ b/src/client/testing/testController/unittest/runner.ts @@ -104,7 +104,9 @@ export class UnittestRunner implements ITestsRunner { runInstance.appendOutput(text); counts.passed += 1; } else if (data.outcome === 'failed') { - const traceback = data.traceback.splitLines({ trim: false, removeEmptyEntries: true }).join('\r\n'); + const traceback = data.traceback + ? data.traceback.splitLines({ trim: false, removeEmptyEntries: true }).join('\r\n') + : ''; const text = `${rawTestCase.rawId} Failed: ${data.message}\r\n${traceback}\r\n`; const message = new TestMessage(text); @@ -119,7 +121,9 @@ export class UnittestRunner implements ITestsRunner { stopTesting = true; } } else if (data.outcome === 'error') { - const traceback = data.traceback.splitLines({ trim: false, removeEmptyEntries: true }).join('\r\n'); + const traceback = data.traceback + ? data.traceback.splitLines({ trim: false, removeEmptyEntries: true }).join('\r\n') + : ''; const text = `${rawTestCase.rawId} Failed with Error: ${data.message}\r\n${traceback}\r\n`; const message = new TestMessage(text); @@ -134,7 +138,9 @@ export class UnittestRunner implements ITestsRunner { stopTesting = true; } } else if (data.outcome === 'skipped') { - const traceback = data.traceback.splitLines({ trim: false, removeEmptyEntries: true }).join('\r\n'); + const traceback = data.traceback + ? data.traceback.splitLines({ trim: false, removeEmptyEntries: true }).join('\r\n') + : ''; const text = `${rawTestCase.rawId} Skipped: ${data.message}\r\n${traceback}\r\n`; runInstance.skipped(testCase); runInstance.appendOutput(text);