Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any functionality related to testing doesn't work if language server is set to none #13713

Closed
karrtikr opened this issue Sep 1, 2020 · 1 comment · Fixed by #16769
Closed
Labels
area-testing bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@karrtikr
Copy link

karrtikr commented Sep 1, 2020

Looks like the activate() method below is always associated with the language server, and is not called if there is no language server being used

public async activate(symbolProvider: DocumentSymbolProvider): Promise<void> {

image

(The language server provides the symbol provider which is used to get codelenses. But having codelenses isn't necessary for testing frameworks to work.)

This means that none of the commands related to testing (python.discoverTests etc.) are registered and testing doesn't work.

@karrtikr karrtikr added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels Sep 1, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 1, 2020
@luabud luabud added the verified Verification succeeded label Jul 29, 2021
@luabud
Copy link
Member

luabud commented Jul 29, 2021

This is fixed by #16769 🥳

@karthiknadig karthiknadig added this to the August 2021 milestone Aug 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants