Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old env sorting and autoselection logic #16935

Closed
8 tasks done
kimadeline opened this issue Aug 11, 2021 · 1 comment · Fixed by #16951
Closed
8 tasks done

Remove old env sorting and autoselection logic #16935

kimadeline opened this issue Aug 11, 2021 · 1 comment · Fixed by #16951
Assignees
@luabud @kimadeline
Labels
area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc. verified Verification succeeded
Milestone
August 2021

Comments

@kimadeline
Copy link

kimadeline commented Aug 11, 2021 •
edited
Loading

Follow-up to #16520

Notes:

  • src/client/interpreter/configuration/interpreterComparer.ts can be deleted.
  • Remember to un-export the getSortName function in src/client/interpreter/configuration/environmentTypeComparer.ts since it won't be used outside of this file anymore.

To remove/update:

  • EnvironmentSorting.experiment
  • IInterpreterAutoSelectionRule
  • EventName.PYTHON_INTERPRETER_AUTO_SELECTION
  • InterpreterComparer
  • InterpreterComparisonType.Default
  • autoSelection/index.ts and index.unit.test.ts
  • sorting
  • usingAutoSelectedWorkspaceInterpreter telemetry
@kimadeline kimadeline added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-environments Features relating to handling interpreter environments labels Aug 11, 2021
@kimadeline kimadeline added this to the August 2021 milestone Aug 11, 2021
@kimadeline kimadeline self-assigned this Aug 11, 2021
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Aug 11, 2021
@kimadeline kimadeline removed the triage-needed Needs assignment to the proper sub-team label Aug 11, 2021
@kimadeline kimadeline mentioned this issue Aug 12, 2021
Merged
@kimadeline kimadeline added the verification-needed Verification of issue is requested label Aug 17, 2021
@kimadeline
Copy link
Author

kimadeline commented Aug 17, 2021 •
edited
Loading

To verify on the telemetry side by @luabud:

  • Check that the EDITOR.LOAD telemetry event does not contain the usingAutoSelectedWorkspaceInterpreter property anymore.

@karthiknadig karthiknadig added verification-needed Verification of issue is requested and removed verification-needed Verification of issue is requested labels Aug 19, 2021
@luabud luabud added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Aug 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luabud luabud

@kimadeline kimadeline

Labels
area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc. verified Verification succeeded
Projects
None yet
Milestone
August 2021
Development

Successfully merging a pull request may close this issue.

Remove old sorting code and auto-selection logic kimadeline/vscode-python
3 participants
@karthiknadig @luabud @kimadeline