Tests are failing on main #18337

kimadeline · 2022-01-21T23:30:35Z

Seems conda-related: https://github.com/microsoft/vscode-python/runs/4900770674?check_suite_focus=true

Started failing with c63d38d

1) PythonExecutableService
       Importing without a valid PYTHONPATH should fail:
     Error: No matching bindings found for serviceIdentifier: Symbol(IConfigurationService)
      at _validateActiveBindingCount (node_modules/inversify/lib/planning/planner.js:63:23)
      at _getActiveBindings (node_modules/inversify/lib/planning/planner.js:49:5)
      at _createSubRequests (node_modules/inversify/lib/planning/planner.js:86:26)
      at Object.plan (node_modules/inversify/lib/planning/planner.js:137:9)
      at /home/runner/work/vscode-python/vscode-python/path with spaces/node_modules/inversify/lib/container/container.js:319:37
      at Container._get (node_modules/inversify/lib/container/container.js:312:44)
      at Container.get (node_modules/inversify/lib/container/container.js:232:21)
      at ServiceContainer.get (out/client/ioc/container.js:24:89)
      at Object.getPythonSetting (out/client/pythonEnvironments/common/externalDependencies.js:112:47)
      at getCandidates (out/client/pythonEnvironments/common/environmentManagers/conda.js:111:60)
      at getCandidates.next (<anonymous>)
      at Function.locate (out/client/pythonEnvironments/common/environmentManagers/conda.js:177:26)
      at Function.getConda (out/client/pythonEnvironments/common/environmentManagers/conda.js:102:39)
      at CondaService.getCondaVersion (out/client/pythonEnvironments/common/environmentManagers/condaService.js:44:30)
      at PythonExecutionFactory.createCondaExecutionService (out/client/common/process/pythonExecutionFactory.js:96:31)
      at PythonExecutionFactory.create (out/client/common/process/pythonExecutionFactory.js:61:50)
      at Context.<anonymous> (out/test/common/process/pythonProc.simple.multiroot.test.js:50:35)


  2) PythonExecutableService
       Importing with a valid PYTHONPATH from .env file should succeed:
     Error: No matching bindings found for serviceIdentifier: Symbol(IConfigurationService)
      at _validateActiveBindingCount (node_modules/inversify/lib/planning/planner.js:63:23)
      at _getActiveBindings (node_modules/inversify/lib/planning/planner.js:49:5)
      at _createSubRequests (node_modules/inversify/lib/planning/planner.js:86:26)
      at Object.plan (node_modules/inversify/lib/planning/planner.js:137:9)
      at /home/runner/work/vscode-python/vscode-python/path with spaces/node_modules/inversify/lib/container/container.js:319:37
      at Container._get (node_modules/inversify/lib/container/container.js:312:44)
      at Container.get (node_modules/inversify/lib/container/container.js:232:21)
      at ServiceContainer.get (out/client/ioc/container.js:24:89)
      at Object.getPythonSetting (out/client/pythonEnvironments/common/externalDependencies.js:112:47)
      at getCandidates (out/client/pythonEnvironments/common/environmentManagers/conda.js:111:60)
      at getCandidates.next (<anonymous>)
      at Function.locate (out/client/pythonEnvironments/common/environmentManagers/conda.js:177:26)
      at Function.getConda (out/client/pythonEnvironments/common/environmentManagers/conda.js:102:39)
      at CondaService.getCondaVersion (out/client/pythonEnvironments/common/environmentManagers/condaService.js:44:30)
      at PythonExecutionFactory.createCondaExecutionService (out/client/common/process/pythonExecutionFactory.js:96:31)
      at PythonExecutionFactory.create (out/client/common/process/pythonExecutionFactory.js:61:50)
      at processTicksAndRejections (internal/process/task_queues.js:93:5)
      at Context.<anonymous> (out/test/common/process/pythonProc.simple.multiroot.test.js:62:35)

  3) PythonExecutableService
       Known modules such as 'os' and 'sys' should be deemed 'installed':
     Error: No matching bindings found for serviceIdentifier: Symbol(IConfigurationService)
      at _validateActiveBindingCount (node_modules/inversify/lib/planning/planner.js:63:23)
      at _getActiveBindings (node_modules/inversify/lib/planning/planner.js:49:5)
      at _createSubRequests (node_modules/inversify/lib/planning/planner.js:86:26)
      at Object.plan (node_modules/inversify/lib/planning/planner.js:137:9)
      at /home/runner/work/vscode-python/vscode-python/path with spaces/node_modules/inversify/lib/container/container.js:319:37
      at Container._get (node_modules/inversify/lib/container/container.js:312:44)
      at Container.get (node_modules/inversify/lib/container/container.js:232:21)
      at ServiceContainer.get (out/client/ioc/container.js:24:89)
      at Object.getPythonSetting (out/client/pythonEnvironments/common/externalDependencies.js:112:47)
      at getCandidates (out/client/pythonEnvironments/common/environmentManagers/conda.js:111:60)
      at getCandidates.next (<anonymous>)
      at Function.locate (out/client/pythonEnvironments/common/environmentManagers/conda.js:177:26)
      at Function.getConda (out/client/pythonEnvironments/common/environmentManagers/conda.js:102:39)
      at CondaService.getCondaVersion (out/client/pythonEnvironments/common/environmentManagers/condaService.js:44:30)
      at PythonExecutionFactory.createCondaExecutionService (out/client/common/process/pythonExecutionFactory.js:96:31)
      at PythonExecutionFactory.create (out/client/common/process/pythonExecutionFactory.js:61:50)
      at processTicksAndRejections (internal/process/task_queues.js:93:5)
      at Context.<anonymous> (out/test/common/process/pythonProc.simple.multiroot.test.js:70:35)

  4) PythonExecutableService
       Unknown modules such as 'xyzabc123' be deemed 'not installed':
     Error: No matching bindings found for serviceIdentifier: Symbol(IConfigurationService)
      at _validateActiveBindingCount (node_modules/inversify/lib/planning/planner.js:63:23)
      at _getActiveBindings (node_modules/inversify/lib/planning/planner.js:49:5)
      at _createSubRequests (node_modules/inversify/lib/planning/planner.js:86:26)
      at Object.plan (node_modules/inversify/lib/planning/planner.js:137:9)
      at /home/runner/work/vscode-python/vscode-python/path with spaces/node_modules/inversify/lib/container/container.js:319:37
      at Container._get (node_modules/inversify/lib/container/container.js:312:44)
      at Container.get (node_modules/inversify/lib/container/container.js:232:21)
      at ServiceContainer.get (out/client/ioc/container.js:24:89)
      at Object.getPythonSetting (out/client/pythonEnvironments/common/externalDependencies.js:112:47)
      at getCandidates (out/client/pythonEnvironments/common/environmentManagers/conda.js:111:60)
      at getCandidates.next (<anonymous>)
      at Function.locate (out/client/pythonEnvironments/common/environmentManagers/conda.js:177:26)
      at Function.getConda (out/client/pythonEnvironments/common/environmentManagers/conda.js:102:39)
      at CondaService.getCondaVersion (out/client/pythonEnvironments/common/environmentManagers/condaService.js:44:30)
      at PythonExecutionFactory.createCondaExecutionService (out/client/common/process/pythonExecutionFactory.js:96:31)
      at PythonExecutionFactory.create (out/client/common/process/pythonExecutionFactory.js:61:50)
      at processTicksAndRejections (internal/process/task_queues.js:93:5)
      at Context.<anonymous> (out/test/common/process/pythonProc.simple.multiroot.test.js:77:35)

  5) PythonExecutableService
       Ensure correct path to executable is returned:
     Error: No matching bindings found for serviceIdentifier: Symbol(IConfigurationService)
      at _validateActiveBindingCount (node_modules/inversify/lib/planning/planner.js:63:23)
      at _getActiveBindings (node_modules/inversify/lib/planning/planner.js:49:5)
      at _createSubRequests (node_modules/inversify/lib/planning/planner.js:86:26)
      at Object.plan (node_modules/inversify/lib/planning/planner.js:137:9)
      at /home/runner/work/vscode-python/vscode-python/path with spaces/node_modules/inversify/lib/container/container.js:319:37
      at Container._get (node_modules/inversify/lib/container/container.js:312:44)
      at Container.get (node_modules/inversify/lib/container/container.js:232:21)
      at ServiceContainer.get (out/client/ioc/container.js:24:89)
      at Object.getPythonSetting (out/client/pythonEnvironments/common/externalDependencies.js:112:47)
      at getCandidates (out/client/pythonEnvironments/common/environmentManagers/conda.js:111:60)
      at getCandidates.next (<anonymous>)
      at Function.locate (out/client/pythonEnvironments/common/environmentManagers/conda.js:177:26)
      at Function.getConda (out/client/pythonEnvironments/common/environmentManagers/conda.js:102:39)
      at CondaService.getCondaVersion (out/client/pythonEnvironments/common/environmentManagers/condaService.js:44:30)
      at PythonExecutionFactory.createCondaExecutionService (out/client/common/process/pythonExecutionFactory.js:96:31)
      at PythonExecutionFactory.create (out/client/common/process/pythonExecutionFactory.js:61:50)
      at Context.<anonymous> (out/test/common/process/pythonProc.simple.multiroot.test.js:95:35)

The text was updated successfully, but these errors were encountered:

kimadeline · 2022-01-24T21:33:15Z

#18338 addresses theses missing service identifiers, but then timeout issues are surfaced:

https://github.com/microsoft/vscode-python/runs/4925250424?check_suite_focus=true

1) PythonExecutableService
 Importing without a valid PYTHONPATH should fail:
 Error: Timeout of 25000ms exceeded. For async tests and hooks, ensure "done()"is called; if returning a Promise, ensure it resolves.(d:\a\vscode-python\vscode-python\path with spaces\out\test\common\process\pythonProc.simple.multiroot.test.js)
 at listOnTimeout (internal/timers.js:554:17)
 at processTimers (internal/timers.js:497:7)
 
2) PythonExecutableService
 Importing with a valid PYTHONPATH from .env file should succeed:
 Error: Timeout of 25000ms exceeded. For async tests and hooks, ensure "done()"is called; if returning a Promise, ensure it resolves.(d:\a\vscode-python\vscode-python\path with spaces\out\test\common\process\pythonProc.simple.multiroot.test.js)
 at listOnTimeout (internal/timers.js:554:17)
 at processTimers (internal/timers.js:497:7)
 
3) PythonExecutableService
 Known modules such as 'os' and 'sys' should be deemed 'installed':
 Error: Timeout of 25000ms exceeded. For async tests and hooks, ensure "done()"is called; if returning a Promise, ensure it resolves.(d:\a\vscode-python\vscode-python\path with spaces\out\test\common\process\pythonProc.simple.multiroot.test.js)
 at listOnTimeout (internal/timers.js:554:17)
 at processTimers (internal/timers.js:497:7)
 
4) PythonExecutableService
 Unknown modules such as 'xyzabc123' be deemed 'not installed':
 Error: Timeout of 25000ms exceeded. For async tests and hooks, ensure "done()"is called; if returning a Promise, ensure it resolves.(d:\a\vscode-python\vscode-python\path with spaces\out\test\common\process\pythonProc.simple.multiroot.test.js)
 at listOnTimeout (internal/timers.js:554:17)
 at processTimers (internal/timers.js:497:7)
 
5) PythonExecutableService
 Ensure correct path to executable is returned:
 Error: Timeout of 25000ms exceeded. For async tests and hooks, ensure "done()"is called; if returning a Promise, ensure it resolves.(d:\a\vscode-python\vscode-python\path with spaces\out\test\common\process\pythonProc.simple.multiroot.test.js)
 at listOnTimeout (internal/timers.js:554:17)
 at processTimers (internal/timers.js:497:7)
 
6) Multiroot Linting
 Enabling Pylint in root and also in Workspace, should return errors:
 Error: Timeout of 50000ms exceeded. For async tests and hooks, ensure "done()"is called; if returning a Promise, ensure it resolves.(d:\a\vscode-python\vscode-python\path with spaces\out\test\linters\lint.multiroot.test.js)
 at listOnTimeout (internal/timers.js:554:17)
 at processTimers (internal/timers.js:497:7)
 
7) Multiroot Linting
 Disabling Pylint in root and enabling in Workspace, should return errors:
 Error: Timeout of 50000ms exceeded. For async tests and hooks, ensure "done()"is called; if returning a Promise, ensure it resolves.(d:\a\vscode-python\vscode-python\path with spaces\out\test\linters\lint.multiroot.test.js)
 at listOnTimeout (internal/timers.js:554:17)
 at processTimers (internal/timers.js:497:7)
 
8) Multiroot Linting
 Enabling Flake8 in root and also in Workspace, should return errors:
 Error: Timeout of 50000ms exceeded. For async tests and hooks, ensure "done()"is called; if returning a Promise, ensure it resolves.(d:\a\vscode-python\vscode-python\path with spaces\out\test\linters\lint.multiroot.test.js)
 at listOnTimeout (internal/timers.js:554:17)
 at processTimers (internal/timers.js:497:7)
 
9) Multiroot Linting
 Disabling Flake8 in root and enabling in Workspace, should return errors:
 Error: Timeout of 50000ms exceeded. For async tests and hooks, ensure "done()"is called; if returning a Promise, ensure it resolves.(d:\a\vscode-python\vscode-python\path with spaces\out\test\linters\lint.multiroot.test.js)
 at listOnTimeout (internal/timers.js:554:17)
 at processTimers (internal/timers.js:497:7)

karrtikr · 2022-01-31T09:39:06Z

  1) PythonExecutableService
       Importing with a valid PYTHONPATH from .env file should succeed:

      AssertionError: expected { Object (stdout, stderr) } to have property 'stdout' of 'Hello\r\n', but got 'Hello\n'
      + expected - actual

      -Hello
      +Hello
      
      at d:\a\vscode-python\vscode-python\path with spaces\node_modules\chai-as-promised\lib\chai-as-promised.js:302:22
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:93:5)
      at Context.<anonymous> (d:\a\vscode-python\vscode-python\path with spaces\out\test\common\process\pythonProc.simple.multiroot.test.js:65:9)

Failing CI due to an extra \r character: https://github.com/microsoft/vscode-python/runs/4986976848?check_suite_focus=true

kimadeline added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team area-internal Label for non-user facing issues labels Jan 21, 2022

kimadeline mentioned this issue Jan 22, 2022

Tests failing on main #18338

Merged

karthiknadig removed the triage-needed Needs assignment to the proper sub-team label Jan 24, 2022

kimadeline added P0 regression Bug didn't exist in a previous release labels Jan 24, 2022

luabud assigned karthiknadig Jan 26, 2022

karthiknadig mentioned this issue Jan 28, 2022

Re-enable tests #18391

Merged

karthiknadig closed this as completed in #18391 Jan 28, 2022

karrtikr reopened this Jan 31, 2022

karthiknadig mentioned this issue Jan 31, 2022

Fix test line endings #18400

Merged

karthiknadig closed this as completed in #18400 Jan 31, 2022

kieferrm mentioned this issue Feb 7, 2022

Python: Iteration Plan for February 2022 #18456

Closed

28 tasks

github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tests are failing on main #18337

Tests are failing on main #18337

kimadeline commented Jan 21, 2022 •

edited

Loading

kimadeline commented Jan 24, 2022 •

edited

Loading

karrtikr commented Jan 31, 2022

Tests are failing on main #18337

Tests are failing on main #18337

Comments

kimadeline commented Jan 21, 2022 • edited Loading

kimadeline commented Jan 24, 2022 • edited Loading

karrtikr commented Jan 31, 2022

kimadeline commented Jan 21, 2022 •

edited

Loading

kimadeline commented Jan 24, 2022 •

edited

Loading