Unittest args doesn't support -t flag

[Fraggle]

This issue: #2162 was closed is was considered a duplicate of another issue.

However, I still can't make vs code discover our tests right now as the "-t" flag is still not supported as a python.testing.unittestArgs.

I confirm that using a terminal to execute the same discovery command but with the -t flag specified works when it doesn't without.

My request is to re-open the issue and add support for -t flag.

[Fraggle]

I digged into the code and I think the fix is relatively easy, actually -t is a "knowOptions" for unittests, however:

Here, when discovery is triggered:
https://github.com/microsoft/vscode-python/blob/master/src/client/testing/unittest/services/discoveryService.ts#L49

There is a third optional argument top_level_dir that should be passed if -t has been specified in the unittestArgs

See https://docs.python.org/2/library/unittest.html#unittest.TestLoader.discover and https://docs.python.org/3/library/unittest.html#unittest.TestLoader.discover

I can provide a PR with the necessary changes that should be limited to https://github.com/microsoft/vscode-python/blob/master/src/client/testing/unittest/services/discoveryService.ts.

[DonJayamanne]

Thanks for the investigation, please do provide a PR.

[ggirard07]

@Fraggle any issue making this more difficult than previously anticipated?

[karrtikr]

We fixed a lot of related code, is this now fixed in the latest version of the extension?

cc @karthiknadig

[eleanorjboyd]

Hi! From my understanding of the extension right now the -t flag can be passed but is not respected. I have been working on this issue and will update progress there #21267.

Lets move to this other issue to consolidate the discussion, thanks!