Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The failed icon of the first fail test doesn't changed to running icon when using unittest framework in "Test" panel #5791

Closed
xiaofeng0123 opened this issue May 27, 2019 · 3 comments · Fixed by #16769
Labels
area-testing bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@xiaofeng0123
Copy link

xiaofeng0123 commented May 27, 2019

Visual Studio Code - Insiders: 1.35.0-insider
python-insider: 2019.5.16887-rc

Repro step:

  1. Input below code:
import unittest
class PassingTests(unittest.TestCase):
    def test_passing(self):
        self.assertEqual(42, 42)
    def test_passing_still(self):
        self.assertEqual("silly walk", "silly walk")
class FailingTests(unittest.TestCase):
    def test_failure(self):
        self.assertEqual(42, -13)
    def test_failure_still(self):
        self.assertEqual("I'm right!", "no, I am!")
    def test_failure_still1(self):
        self.assertEqual("I'm right!", "no, I am!")
  1. Run tests with unittest framework
  2. Select "Test" in "Side" bar
    4.Click "Run All Tests" button
    5.Click "Run Failed Tests" button

Actual Result:
The failed icon of the first fail test doesn't change
unittest_icon

Expect Result:
All icon of failed tests should change

@brettcannon brettcannon added the triage-needed Needs assignment to the proper sub-team label May 28, 2019
@DonJayamanne DonJayamanne self-assigned this May 29, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label May 29, 2019
@ericsnowcurrently
Copy link
Member

Hi @xiaofeng0123. Thanks for letting us know about this. I was able to reproduce the problem (after adding time.sleep(0.2) to each of the tests). We'll work on getting this fixed.

@ericsnowcurrently ericsnowcurrently removed their assignment May 30, 2019
@ericsnowcurrently ericsnowcurrently added area-testing needs PR bug Issue identified by VS Code Team member as probable bug and removed triage labels May 30, 2019
@karrtikr karrtikr added the verification-found Issue verification failed label Jul 29, 2021
@karthiknadig
Copy link
Member

@karrtikr With the latest UI, it only shows progress if the execution takes long. If you add time.sleep(1) before the asserts you will see that it shows progress for each test case as it is run.

@karthiknadig karthiknadig added the verification-needed Verification of issue is requested label Aug 3, 2021
@brettcannon brettcannon added verified Verification succeeded and removed verification-found Issue verification failed verification-needed Verification of issue is requested labels Aug 3, 2021
@brettcannon
Copy link
Member

This has been fixed in the next version of the test UI.

@karthiknadig karthiknadig added this to the August 2021 milestone Aug 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants