Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry 0.12.17 venv not detected #7753

Closed
ViRb3 opened this issue Oct 3, 2019 · 5 comments
Closed

Poetry 0.12.17 venv not detected #7753

ViRb3 opened this issue Oct 3, 2019 · 5 comments
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@ViRb3
Copy link

ViRb3 commented Oct 3, 2019

Environment data

  • VS Code version: 1.38.1
  • Extension version (available under the Extensions sidebar): 2019.9.34911
  • OS and version: Windows 10
  • Python version (& distribution if applicable, e.g. Anaconda): 3.7 vanilla
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): poetry
  • Relevant/affected Python packages and their versions: -
  • Jedi or Language Server?: Language Server

Expected behaviour

VSCode detects poetry venv and allows to select it through the Python version window, like Pipenv

Actual behaviour

VSCode does not detect the poetry venv. I can confirm it works for Pipenv, on the other hand

Steps to reproduce:

poetry init
poetry install ...
poetry lock
echo > main.py
code .
@ViRb3 ViRb3 added triage-needed Needs assignment to the proper sub-team bug Issue identified by VS Code Team member as probable bug labels Oct 3, 2019
@DonJayamanne
Copy link

DonJayamanne commented Oct 3, 2019

Thanks for reporting this issue, closing as it is a fuplicate of #4235 (selecting requires activation and usage of the environment)

Currently the extension only supports poetry as a dependency manager.

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Oct 3, 2019
@ViRb3
Copy link
Author

ViRb3 commented Oct 3, 2019

@DonJayamanne it appears to work in this blog post:
https://www.pythoncheatsheet.org/blog/python-projects-with-poetry-and-vscode-part-2/

Is this only in the Insiders version?

@DonJayamanne
Copy link

Thanks for sharing that with us. I'll re-open this issue to confirm how that works.
Its possible the user has somehow configured something to get it detected.

@DonJayamanne DonJayamanne reopened this Oct 3, 2019
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Oct 3, 2019
@ViRb3
Copy link
Author

ViRb3 commented Oct 3, 2019

After a careful re-read, I just figured it out:

The first command, poetry shell, will spawn us inside our virtual environment, and code . will open the current folder inside VSCode.

@DonJayamanne
Copy link

Thanks, closing again. @karthiknadig /cc
Closing as a dup of the one mentioned in an earlier comment.

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Oct 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants