Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test view: discover tests should keep previous test run state #9606

Closed
isidorn opened this issue Jan 15, 2020 · 2 comments
Closed

Test view: discover tests should keep previous test run state #9606

isidorn opened this issue Jan 15, 2020 · 2 comments
Labels
area-testing feature-request Request for new features or functionality

Comments

@isidorn
Copy link

isidorn commented Jan 15, 2020

Test view, run some tests: they might be green / red
Click on the discover tests button -> tests are in the ? state. The previous state should be respected, discovering new tests should not change the run state of my already run tests.

@luabud

test

@isidorn isidorn added data science bug Issue identified by VS Code Team member as probable bug labels Jan 15, 2020
@luabud
Copy link
Member

luabud commented Jan 15, 2020

@isidorn I feel that if test discovery is triggered, it should refresh the state of the tests (and that's also the reason why we chose the "refresh" icon for this). If the user makes changes and triggers test discovery again, retaining the previous state will show now an incorrect state. If the name of the test changes as well as its result, what would be the expected state, in this case?
Personally, I think "unknown" makes sense for all of these cases.
Anyway, tagging it as "needs decision" so I can talk to the team about it 😊

@luabud luabud added area-testing needs decision feature-request Request for new features or functionality and removed data science bug Issue identified by VS Code Team member as probable bug labels Jan 15, 2020
@isidorn
Copy link
Author

isidorn commented Jan 16, 2020

Makes sense, good arguments. I have changed my mind, thus closing this so you do not have to bring it up in your team meeting. Thanks.

@isidorn isidorn closed this as completed Jan 16, 2020
@ghost ghost removed the needs decision label Jan 16, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants