Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: chrome attachment in remote scenario #105772

Closed
3 tasks done
connor4312 opened this issue Aug 31, 2020 · 2 comments
Closed
3 tasks done

Test: chrome attachment in remote scenario #105772

connor4312 opened this issue Aug 31, 2020 · 2 comments

Comments

@connor4312
Copy link
Member

connor4312 commented Aug 31, 2020

Refs: microsoft/vscode-js-debug#456

Complexity: 2

Create Issue


Previously in remotes, we only attached via stdio pipes. There was work this iteration to add parity to allow attaching to browsers running the UI, as well as launching browsers with debug ports rather than pipes. You can test both of these things at once!

From a remote environment (container, ssh, or wsl), have a folder with .vscode/launch.json

{
  "version": "0.2.0",
  "configurations": [
    {
      "type": "pwa-chrome",
      "request": "launch",
      "name": "launch",
      "url": "https://github.com",
    },
    {
      "type": "pwa-chrome",
      "request": "attach",
      "name": "attach",
      "address": "127.0.0.1",
      "port": 9229,
    }
  ]
}

  1. Run "launch". Verify that a browser opens to github.com. Check that it works, enter document in the Debug Console and see that it exists.
  2. Run "attach". This should not work and eventually time out (or you can cancel it)
  3. Add "port": 9229 to "launch". Stop the running debug session, and then run it again.
  4. Now run "attach". It should successfully attach.
@connor4312 connor4312 added this to the August 2020 milestone Aug 31, 2020
@fiveisprime fiveisprime removed their assignment Sep 1, 2020
@fiveisprime
Copy link
Member

Looks good

Tested on Windows with Remote-WSL and with some of my personal JAMstack apps. It's nice to see this working!

@btholt btholt removed their assignment Sep 1, 2020
@btholt
Copy link

btholt commented Sep 1, 2020

Tested on a create-react-app with a Node.js dev container.

This is siiiiiick. People are going to love it.

@mjbvz mjbvz removed their assignment Sep 2, 2020
@mjbvz mjbvz closed this as completed Sep 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants