Horizontal space is not being used fully by the test message

[jdneo]

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.57.0-insider
Commit: 40d5e67
Date: 2021-05-14T21:31:25.085Z
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Darwin x64 20.4.0

Steps to Reproduce:

1. Use the new test API and append a markdown string as a test message
2. The horizontal space is not being used fully by the test message

// #122208 (comment)

[connor4312]

@mjbvz this is a bug in the hover itself (testing just uses the default hovers). Notice that the long method name/path increases the size of the hover, but its contents don't grow to fit/the name doesn't scroll.

working-areas.md says Pine still owns this--is the bot right that you're the new hover person, or is there someone else?

[mjbvz]

Maybe @alexdima or @jrieken? Not sure if there is a dedicated owner for hovers at the moment

[alexdima]

@connor4312 I'm maintaining the hover but would appreciate a PR / some simpler repro steps maybe with a trivial extension that just registers a hover provider with the same markdown content.

[jdneo]

@alexdima You can use this sample project: https://github.com/jdneo/vscode-extension-samples/tree/cs/vscode-issue-123927/test-provider-sample.

1. npm i
2. running the sample extension in VS Code Insider.
3. Open test.md
4. Click the green button for the line 2 + 2 = 5.
5. After run finished, hover on it.

See below video:

Video1.mp4

[alexdima]

Thank you for the repro. Here is a further reduced repro for an extension that can be placed in the user extensions dir:

• package.json:

{
  "name": "123927",
  "publisher": "alex",
  "version": "1.0.0",
  "engines": {
    "vscode": "^1.22.0"
  },
  "activationEvents": [
    "*"
  ],
  "main": "index.js"
}

• index.js:

const vscode = require("vscode");

exports.activate = function () {
  vscode.languages.registerHoverProvider(
    { scheme: "file" },
    {
      provideHover: () => {
        const markdownString = new vscode.MarkdownString();
        markdownString.appendCodeblock(
          "void org.springframework.samples.petclinic.model.ValidatorTest.shouldNotValidateWhenFirstNameEmpty()",
          "java"
        );
        return new vscode.Hover(markdownString);
      },
    }
  );
  vscode.languages.registerHoverProvider(
    { scheme: "file" },
    {
      provideHover: () => {
        const markdownString = new vscode.MarkdownString();
        markdownString.isTrusted = true;
        markdownString.appendText(
          "this is just a fake lonnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnng [message](https://github.com/microsoft/vscode/issues/123927#issuecomment-853149197)"
        );
        return new vscode.Hover(markdownString);
      },
    }
  );
};

[yash112-lang]

Hello @alexdima, is this issue is still open, I am new to open source and wanted to contribute.

[connor4312]

I played around with this. I'm not sure it's possible to fix this with the way word wrapping works. At least not without manually doing width/height computation on elements.

[connor4312]

This is a tricky situation for an edge case. I'm leaning towards closing this as *wontfix; I can't figure a way to do this in CSS and manually laying it out with JS will add a deal of complexity and is likely to be error-prone.