Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage new support for markdown in timeline hovers for the git contribution #144397

Closed
egamma opened this issue Mar 4, 2022 · 2 comments
Closed

Leverage new support for markdown in timeline hovers for the git contribution #144397

egamma opened this issue Mar 4, 2022 · 2 comments
Assignees
@lszomoru @lychung7
Labels
feature-request Request for new features or functionality scm General SCM compound issues timeline-git Timeline view issues with Git history ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
March 2022

Comments

@egamma
Copy link
Member

egamma commented Mar 4, 2022

There is now support for using Markdown in timeline hovers, this should be used to embellish the current Git hover with improved formatting, emojis, avatar, and command links. This is the existing hover:

image

Here are some examples for how Markdown is leveraged in hovers:

Remote Explorer/remote containers:
image

Remote Explorer/codespaces
image

GitLens
image
@kieferrm kieferrm mentioned this issue Mar 6, 2022
Closed
87 tasks
@lszomoru lszomoru mentioned this issue Mar 9, 2022
Closed
@miguelsolorio miguelsolorio added this to the March 2022 milestone Mar 9, 2022
@lychung7 lychung7 added the ux User experience issues label Mar 17, 2022
@lszomoru lszomoru added scm General SCM compound issues timeline-git Timeline view issues with Git history feature-request Request for new features or functionality labels Mar 21, 2022
@lszomoru
Copy link
Member

In the first iteration we have settled on using links and codicons.
We will be exploring whether it makes sense to also add actions to the hover.

image

@lszomoru
Copy link
Member

Verification steps:

  1. Open a folder/workspace that contains a git repository
  2. Open an file in the editor
  3. Open the Timeline view, and filter the view to "Git History"
  4. Hover over multiple changes and confirm that the hover information renders correctly

@lszomoru lszomoru added the verification-needed Verification of issue is requested label Mar 21, 2022
@jrieken jrieken added the verified Verification succeeded label Mar 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lszomoru lszomoru

@lychung7 lychung7

Labels
feature-request Request for new features or functionality scm General SCM compound issues timeline-git Timeline view issues with Git history ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
March 2022
Development

No branches or pull requests
5 participants
@egamma @jrieken @lszomoru @miguelsolorio @lychung7