Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlay hints cover up horizontal bracket pair guides #147790

Open
jjspace opened this issue Apr 20, 2022 · 3 comments
Open

Inlay hints cover up horizontal bracket pair guides #147790

jjspace opened this issue Apr 20, 2022 · 3 comments
Assignees
Labels
bracket-pair-guides inlay-hints under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@jjspace
Copy link

jjspace commented Apr 20, 2022

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.66.2
  • OS Version: Kubuntu 20.04

Steps to Reproduce:

  1. Turn on a set of inlayHints that creates hints on the same line as an open bracket (like in a function call/definition)
  2. Turn on editor.bracketPairColorization and set editor.bracketPairs to true or active
  3. move the cursor so a horizontal pair guide is shown through the inlay hints and observe the horizontal line is covered up by the inlay background (may have to play with inlay background color depending on your theme).

The video below shows this problem and also a work around I found. Changing the editor.inlayHints.fontSize to smaller can shrink the whole inlay element so it's no longer obstructing the horizontal line. Alternatively you can set the editorInlayHint.background color to have transparency which lets the horizontal guide show through some.

Ideally these shouldn't conflict. Maybe the inlay hints need to be moved up so they can never overflow below the line of code's baseline or the horizontal guide needs to be drawn on top of everything. As it is I think it looks bad and incohesive to have the horizontal guide get broken up like this

simplescreenrecorder-2022-04-20_13.32.45.mp4
@hediet hediet assigned jrieken and hediet and unassigned hediet Apr 21, 2022
@hediet hediet added this to the Backlog milestone Apr 21, 2022
@hediet hediet added bug Issue identified by VS Code Team member as probable bug under-discussion Issue is under discussion for relevance, priority, approach labels Apr 21, 2022
@jjspace
Copy link
Author

jjspace commented Apr 26, 2022

I realized today that this affects the "error" and "warning" squiggly lines too
2022-04-26_09-54

And the same opacity trick works
2022-04-26_09-52_1

@jrieken jrieken modified the milestones: Backlog, April 2022 Apr 26, 2022
@jrieken
Copy link
Member

jrieken commented Apr 26, 2022

@hediet Let's tackle this in April, I believe its just a matter of us agreeing on some (static) priority and using appropriate zIndex rules.

@jrieken jrieken removed the bug Issue identified by VS Code Team member as probable bug label Apr 27, 2022
@jrieken
Copy link
Member

jrieken commented Apr 27, 2022

Screenshot 2022-04-27 at 11 28 31

The original issue, the conflict with bracket pair lines, doesn't occur anymore because of the work done for #145191. Inlays used to be padded but aren't anymore. The other aspect, the overlay between the squiggle and inlay hint background, is still an issue. The easiest workaround is to customise the theme color to be slightly transparent (as shown above).

@jrieken jrieken removed this from the April 2022 milestone Apr 27, 2022
@hediet hediet added this to the Backlog milestone Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bracket-pair-guides inlay-hints under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants