Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems view table - source column does not show ... #150835

Closed
sandy081 opened this issue May 31, 2022 · 2 comments
Closed

Problems view table - source column does not show ... #150835

sandy081 opened this issue May 31, 2022 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug error-list Problems view verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

Testing #150750

Create an extension that generate diagnostics without source set and you see following:

image

const diagnosticCollection = vscode.languages.createDiagnosticCollection();
const diagnostics: vscode.Diagnostic[] = [];
 diagnostics.push(new vscode.Diagnostic(new vscode.Range(new vscode.Position(0, 0), new vscode.Position(0, 0)), `test`, vscode.DiagnosticSeverity.Error));
diagnosticsCollection.set(uri, diagnostics);

Also if the source name is longer, it is trimmed off and can't resize the source column to see completely.

I wonder if it is necessary to show source and I think we do not show it in tree mode

@lszomoru lszomoru added error-list Problems view bug Issue identified by VS Code Team member as probable bug labels May 31, 2022
@lszomoru lszomoru added this to the June 2022 milestone May 31, 2022
@lszomoru
Copy link
Member

Users do want to have the ability to "group" the problems by source so it does make sense to display the source as it allows users to filter the problems based on their source. Having said that, I do agree that we need to make sure that the complete source can be shown.

@lszomoru lszomoru changed the title Generated source is shown when source is not provided by the extension Problems view table - source column does not show ... Jun 14, 2022
@lszomoru
Copy link
Member

Pushed changes to:

  • increase the maximum width of the "Code" and "Source" columns to have the ability to expand them
  • fixed an issue where text overflow ellipsis was not showing correctly on the "Source" column
  • there is now a tooltip which should help seeing the complete contents of a column

@sandy081 sandy081 added the verified Verification succeeded label Jun 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug error-list Problems view verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants