Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open Folder" not translated in walkthrough #150908

Closed
bamurtaugh opened this issue May 31, 2022 · 5 comments · Fixed by #158053
Closed

"Open Folder" not translated in walkthrough #150908

bamurtaugh opened this issue May 31, 2022 · 5 comments · Fixed by #158053
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Milestone

Comments

@bamurtaugh
Copy link
Member

bamurtaugh commented May 31, 2022

Testing #150577 in Firefox, with Spanish (es-es) set

  • Open "Get Started with VS Code in the Web" walkthrough
  • Select last step (open up your code), then first command ("Open Folder" in English, "Abrir carpeta" in Spanish)
  • Modal is in English:

image

It isn't a new string, and I didn't think getting started or this command would be from an extension, but perhaps that is the case.

@bamurtaugh
Copy link
Member Author

I also see this on modals on the overall welcome page when I try opening a file or folder:

image

@csigs
Copy link
Member

csigs commented May 31, 2022

Thank you for your feedback. We are currently reviewing it (reference 625047).

@TylerLeonhardt
Copy link
Member

This is an odd one. The string looks good here:

localize('unsupportedBrowserMessage', "Opening Local Folders is Unsupported"),
buttons,
{
detail: localize('unsupportedBrowserDetail', "Your browser doesn't support opening local folders.\nYou can either open single files or open a remote repository."),
cancelId: -1 // no "Cancel" button offered

but the file that that comes from doesn't show up at all in our Spanish files:
https://github.com/microsoft/vscode-loc-drop/blob/main/src/vscode-workbench/es/vs_workbench_services_dialogs.xlf

I'll have to dig into why this is... @dbaeumer any ideas?

@TylerLeonhardt TylerLeonhardt transferred this issue from microsoft/vscode-loc May 31, 2022
@TylerLeonhardt TylerLeonhardt added bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations) labels May 31, 2022
@TylerLeonhardt TylerLeonhardt added this to the Backlog milestone May 31, 2022
@dbaeumer
Copy link
Member

dbaeumer commented Jun 2, 2022

@TylerLeonhardt

might be a bug in the tool so that the localize call is not detected. When you generate the export is the string included.

@TylerLeonhardt TylerLeonhardt modified the milestones: Backlog, June 2022 Jun 13, 2022
@TylerLeonhardt TylerLeonhardt modified the milestones: June 2022, July 2022 Jun 27, 2022
@TylerLeonhardt TylerLeonhardt modified the milestones: July 2022, August 2022 Jul 29, 2022
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Aug 15, 2022
@TylerLeonhardt
Copy link
Member

Ok the web strings are now bundled in language packs. It may take a minute for all these new strings to make their way through the translation system... but by end game it should be good.

@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 16, 2022
@joyceerhl joyceerhl added verified Verification succeeded and removed verified Verification succeeded labels Aug 24, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Aug 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants