Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Electron sandbox #155827

Closed
3 tasks done
bpasero opened this issue Jul 21, 2022 · 2 comments
Closed
3 tasks done

Test: Electron sandbox #155827

bpasero opened this issue Jul 21, 2022 · 2 comments
Labels
sandbox Running VSCode in a node-free environment testplan-item
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jul 21, 2022

Refs: #154006

Complexity: 5

Create Issue


For the sandbox testing, make sure to configure "window.experimental.useSandbox": true and restart. You can check devtools for when sandbox is really enabled:

image

This is an exploratory test plan item while running with sandbox enabled.

Note: keep the setting also enabled in your selfhost build for broader coverage 🚀

Functionality

  • open files and folders and do basic editing, including language features and watch the Developer Tools console for suspicious errors or general issues while doing so
  • go through all our views and panels and check they open and work for the intent they are made for
  • also try non standard editors like a notebook and a custom editor for they work fine
  • open multiple windows, close some and verify you always have 1 extension host process per window (use the Help > Open Process Explorer to find the processes)
  • develop a simple hello world extension (yo code) and verify debugging and extension tests work
  • watch out for actions that seem slow or cause spinners to appear, overall VSCode should not run any noticeably slower when sandbox is enabled but it will have a slight performance impact because of process isolation
  • briefly test that screen reader works and announces the focused element properly (documentation)
  • macOS/Windows: run VSCode as admin with a fresh --user-data-dir and verify the window opens and generally it works without crashes

Development

  • use Developer Tools for setting a breakpoint and verify you can debug VSCode insiders as before
  • similar, run a performance trace and verify it works and it can be displayed in Developer Tols
@mjbvz
Copy link
Collaborator

mjbvz commented Jul 26, 2022

Amazing work! I went through the test plan and have also been running with this setting enabled for a few days. Works great

One question: when I tried to profile my extensions using the running extensions view, I saw a notification that a restart was required. Is this new? I feel like I have not seen it before enabling the sandbox flag

@mjbvz mjbvz removed their assignment Jul 26, 2022
@bpasero
Copy link
Member Author

bpasero commented Jul 27, 2022

@mjbvz thanks, you probably saw #155987

@benibenj benibenj removed their assignment Jul 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
sandbox Running VSCode in a node-free environment testplan-item
Projects
None yet
Development

No branches or pull requests

4 participants