-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate WS_THICKFRAME impact when creating frameless windows #158065
Comments
|
In Visual Studio, I got an older-looking frame to show up by calling The older-looking frame kept showing up until I added I also noticed that |
@deepak1556 thought it was strange that the styles kept changing, whereas I just took the styles changing for granted other than the I annotated an example of the styles changing below:
It turns out the That if statement arises due to https://codereview.chromium.org/9372053/, with a comment that states that "[The if statement] removes the unsightly close button visible in the frame during startup and resizing". I still have to check whether commenting out that code causes that glitch to show up again, considering Electron has its own style that it applies to the window anyway. For non-resizable windows, I haven't seen any regression. I still have to test the change for resizable windows, though. The code review also links to images, but those links are dead, so I'm unable to see what the glitchy behaviour looked like. Edit: we hit that if statement in the first place due to |
Upstream: electron/electron#30024 |
TODO:
Verification steps if needed:
Note that #146683 already gets rid of the Windows 7 frame showing up during launch, but this issue tracks an alternative solution for Electron that is simpler and applicable to a larger class of frameless windows. |
This is now addressed. |
Continuation of #146683
The text was updated successfully, but these errors were encountered: