Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Windows 11 context menu entry #164465

Closed
2 tasks done
joaomoreno opened this issue Oct 24, 2022 · 7 comments
Closed
2 tasks done

Test: Windows 11 context menu entry #164465

joaomoreno opened this issue Oct 24, 2022 · 7 comments

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Oct 24, 2022

Refs: #127365

Complexity: 3

Authors: @deepak1556, @joaomoreno

Create Issue


Introduction

Up until now, selecting both Add "Open with Code - Insiders" action to Windows Explorer... actions would
make the actions available in the old File Explorer context menu. This context menu is reachable by right-clicking a file or directory and selecting Show more options.

image

image

image

This new feature adopts the new Windows 11 context menu and makes sure VS Code appears in it:

image

Prerequisites

Download both the user and system setup packages of an old version, as well as the new version:

Test

As you go through the following test cases, keep an eye out for weirdness, error dialogs, etc. Everything should be as smooth as butter. Please run the entire test case suite twice: once for the user setup, and again for the system setup.

Make sure the menu entry works:

  1. Install VS Code, choose the option to add to the context menu.
  2. Make sure that the menu is present when right-clicking on files/directories. Make sure that clicking it does the right thing.
  3. Uninstall VS Code.
  4. Make sure that the menu is gone.

Make sure not choosing the option is reflected:

  1. Install VS Code, don't choose the option to add to the context menu.
  2. Make sure that the menu is not present when right-clicking on files/directories.
  3. Uninstall VS Code.

Make sure updating from an older version preserves the menu:

  1. Install the old version of VS Code, choose the option to add to the context menu.
  2. Make sure that the menu is present when right-clicking on files/directories on the old menu.
  3. In VS Code, run Developer: Apply Update... and pick the new version installer (the same type of setup). Go through the full update, including the app restart.
  4. Make sure that the menu is present when right-clicking on files/directories on the new menu.
  5. Make sure only one menu item is present when right-clicking on files/directories on the old menu.
  6. Uninstall VS Code.
  7. Make sure that the menu is gone.

Make sure updating from an older version preserves the lack of menu:

  1. Install the old version of VS Code, don't choose the option to add to the context menu.
  2. Make sure that the menu is not present when right-clicking on files/directories on the old menu.
  3. In VS Code, run Developer: Apply Update... and pick the new version installer (the same type of setup). Go through the full update, including the app restart.
  4. Make sure that the menu is not present when right-clicking on files/directories on the new menu.
  5. Make sure only one menu item is not present when right-clicking on files/directories on the old menu.
  6. Uninstall VS Code.

Make sure regular update scenario works:

  1. Install VS Code, choose the option to add to the context menu.
  2. Make sure that the menu is present when right-clicking on files/directories.
  3. In VS Code, run Developer: Apply Update... and pick the same version installer (the same type of setup). Go through the full update, including the app restart.
  4. Make sure that the menu is present when right-clicking on files/directories.
  5. Uninstall VS Code.
@alexr00
Copy link
Member

alexr00 commented Oct 25, 2022

I only see one checkbox, and when I right click on a directory after installing there is no option to open in VS Code, even if I expand the More Options Edit: you need to refresh your explorer:

image

@alexr00
Copy link
Member

alexr00 commented Oct 25, 2022

With the system installer there doesn't seem to be a Developer: Apply Update command. I'm blocked testing the system installer update test paths.

Edit: it's still there, just need to disable background updates first.

@cwebster-99
Copy link
Member

I only see one checkbox, and when I right click on a directory after installing there is no option to open in VS Code, even if I expand the More Options:

image

I only had one checkbox in the new version, but was able to see the context menu by checking just the one.

@alexr00
Copy link
Member

alexr00 commented Oct 25, 2022

It seems like this usually doesn't work for me: #164627

@cwebster-99
Copy link
Member

cwebster-99 commented Oct 25, 2022

I was able to run through the scenarios and get the desired outcomes. On the scenarios that required an update of the old version, Developer: Apply Update did not work but if I used the Code - Insiders: Restart to Update I was able to update and observe the desired outcome for each of the scenarios.

@dbaeumer
Copy link
Member

@alexr00 there seems to be some update problems when testing this in a Windows Sandbox due to the fact that the sandbox user has Administrator rights.

@aeschli
Copy link
Contributor

aeschli commented Oct 27, 2022

We discussed in the standup that 2 reviewers are good enough, therefore there's no need for @alexr00 to complete the testing. Marking the issue as tested and closing it.

@aeschli aeschli closed this as completed Oct 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants