Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Electron 27 update #199048

Closed
3 tasks done
deepak1556 opened this issue Nov 24, 2023 · 7 comments
Closed
3 tasks done

Test: Electron 27 update #199048

deepak1556 opened this issue Nov 24, 2023 · 7 comments

Comments

@deepak1556
Copy link
Collaborator

deepak1556 commented Nov 24, 2023

Refs: #196941

Complexity: 4

Create Issue


We plan to promote Electron 27 in the December 2023 milestone to insiders. The following tests cover some of the common UI bits that don't have smoke tests. You can download the nightly explorations builds from here for testing.

Testing:

  • macOS:

    • Enable Native Tabs (via settings: window.nativeTabs: true)
      • Ensure native tabs are enabled in the system preferences (System Preferences > General > Prefer tabs: "always":)
      • Launch application
      • Try opening new window from either command line (code-exploration ) or from the menu entry (Cmd + Shift + N)
      • Verify new window is launched as a new tab in the active instance of the application window is focused when starting from command line
      • open the code exploration application from finder or dock
      • open external terminal
      • run code-exploration
      • make sure the new window is put to foreground
  • windows:

    • touch device, verify onscreen keyboard doesn't pop up when clicking inside vscode while external keyboard is attached
    • verify maximize and restore operations work as expected when OS task bar is auto-hidden for custom titlebar
    • Verify titlebar is not clipped off when exiting fullscreen
      • Maximize VS Code window
      • Press F11 or Ctrl+K Z twice to enter/exit full screen.
      • Verify titlebar is not cropped
    • Verify there is no rendering lag with custom titlebar
  • linux:

  • All OS:

    • Check out the electron-27.x.y branch locally and verify you can run out of sources, set a breakpoint and debug using the VS Code launch configurations and VS Code debugger
@lszomoru
Copy link
Member

Updated the download link to show dev builds as well.

@lszomoru
Copy link
Member

@deepak1556, I was unable to test touch on Windows as I only have Windows VMs.
Other than that, everything worked as expected.

@lszomoru lszomoru removed their assignment Nov 28, 2023
@sbatten
Copy link
Member

sbatten commented Nov 28, 2023

When trying to build on Ubuntu 18.04, I encountered this issue nodesource/distributions#1392.

@sbatten
Copy link
Member

sbatten commented Nov 28, 2023

When trying to build on Fedora 35, I encountered
image

@sbatten sbatten removed their assignment Nov 28, 2023
@paulacamargo25 paulacamargo25 removed their assignment Nov 28, 2023
@deepak1556
Copy link
Collaborator Author

@sbatten fedora is just missing c++ toolchain, you can make it happy by installing the prerequisites mentioned at https://github.com/microsoft/vscode/wiki/How-to-Contribute#prerequisites. But this is good enough, CI already ensures the build part so no need to test it again.

@sbatten
Copy link
Member

sbatten commented Nov 29, 2023

@deepak1556 I followed all steps in How to Contribute and still had this issue.

@deepak1556
Copy link
Collaborator Author

If you still have the vm around, what does g++ --version print ?

@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants