Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colors should be equal or more different #199350

Closed
alexdima opened this issue Nov 28, 2023 · 2 comments
Closed

Colors should be equal or more different #199350

alexdima opened this issue Nov 28, 2023 · 2 comments
Assignees
@hbons @hediet
Labels
diff-editor Diff editor issues polish Cleanup and polish issue
Milestone
On Deck

Comments

@alexdima
Copy link
Member

Testing #199155

Right now the gray in the margin is slightly different than the gray in the hidden lines info bar. IMHO we should either make them equal or make them more different, the shades are very close now which makes it feel like something is off.

image
@hediet hediet added polish Cleanup and polish issue diff-editor Diff editor issues labels Nov 28, 2023
@hediet hediet added this to the On Deck milestone Nov 28, 2023
@hbons
Copy link
Member

hbons commented Nov 28, 2023

agree. @hediet can we use the same grey background as the gutter for the hidden lines?

@hbons
Copy link
Member

hbons commented Nov 30, 2023

Keeping this in mind in #199351

@hbons hbons closed this as completed Nov 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hbons hbons

@hediet hediet

Labels
diff-editor Diff editor issues polish Cleanup and polish issue
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
3 participants
@hbons @hediet @alexdima