Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find in all files should sort by priority #19939

Closed
d-akara opened this issue Feb 4, 2017 · 4 comments
Closed

Find in all files should sort by priority #19939

d-akara opened this issue Feb 4, 2017 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality search Search widget and operation issues

Comments

@d-akara
Copy link

d-akara commented Feb 4, 2017

Find in all files should sort using the following priority by default:

  1. Results in current active file
  2. Results in opened files
  3. Results in recent files
  4. All other files

Brackets all file search for example does a sorting similar to the above which is very useful.

There should be a button to also do an alphabetical sort.

@d-akara
Copy link
Author

d-akara commented Feb 5, 2017

@bpasero Without comment, I'm not sure why the dislike.
This was a very popular feature for Brackets. I can understand not wanting to change default behavior, but seems this would be useful as an option.

This provides the following benefits which have been requested separately:

It seems it would be useful that a user could then choose sorting priority method such as:

  • current vscode default
  • active/open file priority
  • number of hits
  • alphabetical

@roblourens roblourens added the feature-request Request for new features or functionality label Feb 5, 2017
@bpasero
Copy link
Member

bpasero commented Feb 5, 2017

Not much to comment here other than I like our current sorting (strictly alphabetical to workspace context) and I would not benefit from any other sorting. It is the same sorting I have in the explorer and in git changes view.

For me search results are about being complete, not about things like recency. If I do a search I expect the order to be according to file/folder sorting rules.

This is much different in quick open for files where I want the last used file to be first.

@d-akara
Copy link
Author

d-akara commented Feb 5, 2017

Ahh thanks. I actually did not understand how it is currently sorted. In a project with thousands of folders, the results don't seem to have an order, but now I do see the pattern.

For me there are 2 general search cases:

  • Completeness: In this case, sort order is probably not even important generally for me. I just need to know if this term exists anywhere, how many matches, and all files containing term.
  • Current task workflow: In this case, I have set of tasks I'm working. I want to know where a term exists in all files I'm currently working as the term may be a term used throughout the project, but the scope of interest is related to my current working context. This might not seem apparently useful for smaller projects, but in my case working on something on the scale of million lines of code it is useful.

As an alternative, some type of method to more quickly apply scoping could also work for my use case. I haven't found folder organization usually important, but that could be due to my projects folder structure which is too large and deep to be useful in the results view.

@chrmarti chrmarti added the search Search widget and operation issues label Apr 17, 2017
@roblourens
Copy link
Member

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

4 participants