Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An editor is being restored when I use workbench.action.focusLeftGroup in empty group #50693

Closed
Tyriar opened this issue May 29, 2018 · 3 comments
Assignees
Labels
info-needed Issue requires more information from poster workbench-editor-grid Grid layout issues in the editor area

Comments

@Tyriar
Copy link
Member

Tyriar commented May 29, 2018

VS Code version: Code - Insiders 1.24.0-insider (41a7c49, 2018-05-29T06:09:34.618Z)
OS version: Windows_NT x64 10.0.16299


#50458

Starting state (right editor is focused):

image

Trigger this keybinding:

{ "key": "alt+left",        "command": "workbench.action.focusLeftGroup", "when": "editorTextFocus" },

Results in:

image

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug workbench-editor-grid Grid layout issues in the editor area labels May 29, 2018
@vscodebot vscodebot bot added the insiders label May 29, 2018
@bpasero bpasero added this to the May 2018 milestone May 29, 2018
@bpasero
Copy link
Member

bpasero commented May 30, 2018

@Tyriar I cannot reproduce and by looking at the implementation of the action (here) I see no code that would ever open an editor.

Can you reproduce reliably? Could it be that some other command got executed because you have a keybinding collision?

@bpasero bpasero removed this from the May 2018 milestone May 30, 2018
@bpasero bpasero added info-needed Issue requires more information from poster and removed bug Issue identified by VS Code Team member as probable bug insiders labels May 30, 2018
@Tyriar
Copy link
Member Author

Tyriar commented May 30, 2018

@bpasero I don't think it would be a keybinding conflict, when I was in this state it would happen about 75% of the time when moving left.

Cannot repro now on a different machine, I'm fine if you close this as as not reproducible as nothing looks wrong from the code to me either, it was definitely happening though 🙂

@bpasero
Copy link
Member

bpasero commented May 30, 2018

Ok, ping when it happens again.

@bpasero bpasero closed this as completed May 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Development

No branches or pull requests

2 participants