Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Show modified makes editing workspace/folder setting more cumbersome #50709

Closed
octref opened this issue May 29, 2018 · 2 comments
Closed
Assignees
Labels
*out-of-scope Posted issue is not in scope of VS Code settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@octref
Copy link
Contributor

octref commented May 29, 2018

#50496

Currently, the flow of working with workspace/folder settings has been

  • Go to workspace settings (json)
  • I can immediately see which settings are changed
    • If I want to change existing settings, I can find them easily
    • If I want to add new setting, I can use IntelliSense to search

However with the GUI, I lose some of the benefits:

  • I can no longer immediately see which settings are being changed when I go to workspace settings
  • I need to click "Show modified only" to change them
  • Now if I want to change a setting that's not being modified yet, I need to toggle "Show modified only" off again. Otherwise the setting won't even show up in search.
  • After I make the change, I still can't see all changed settings in a glance.

I suggest having a "Modified" section on top of all sections in workspace/folder settings.

@roblourens
Copy link
Member

I suggest having a "Modified" section on top of all sections in workspace/folder settings.

Not a bad idea.

Otherwise, I would just persist the "show modified only" state, and also the checkbox would not impact search (it's supposed to work this way already, that's a bug)

@roblourens roblourens added settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach labels May 29, 2018
@roblourens roblourens added this to the June 2018 milestone May 29, 2018
@roblourens roblourens modified the milestones: June 2018, July 2018 Jun 28, 2018
@roblourens roblourens modified the milestones: July 2018, August 2018 Aug 2, 2018
@roblourens roblourens removed this from the August 2018 milestone Aug 27, 2018
@roblourens roblourens added the *out-of-scope Posted issue is not in scope of VS Code label Sep 13, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 13, 2018

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*out-of-scope Posted issue is not in scope of VS Code settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants