Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test previewOptions in search provider #57305

Closed
2 tasks done
roblourens opened this issue Aug 28, 2018 · 1 comment
Closed
2 tasks done

Test previewOptions in search provider #57305

roblourens opened this issue Aug 28, 2018 · 1 comment

Comments

@roblourens
Copy link
Member

roblourens commented Aug 28, 2018

Testing #57186

Complexity: 3

Write an extension that uses findTextInFiles, and verify that previewOptions is respected properly.

Try some different text searches and verify that builtin search returns the correct preview, and that clicking on a result highlights the correct range in the editor. When the search view is narrow, the preview will be shorter than when it is wide (like when it's in the panel).

Test it with "searchRipgrep.enable": true and false

And you could verify #31551 since this change also fixed that.

@sbatten
Copy link
Member

sbatten commented Aug 28, 2018

verified other issue and left comments in opened issue

@sbatten sbatten removed their assignment Aug 28, 2018
@sbatten sbatten closed this as completed Aug 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants